Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HD wallet creation should be on welcome screen #82

Closed
orogvany opened this issue Nov 7, 2018 · 6 comments
Closed

HD wallet creation should be on welcome screen #82

orogvany opened this issue Nov 7, 2018 · 6 comments
Labels
feature Request a new feature
Milestone

Comments

@orogvany
Copy link
Collaborator

orogvany commented Nov 7, 2018

HD wallet creation/import should be on welcome screen.

We also need to decide on some text to show what it is, and what to do with it.

It's unclear right now that the HD key password can be different than main wallet password.

@mdodong
Copy link
Contributor

mdodong commented Nov 7, 2018

I suggest we remove the HD key password coz this can add confusion to many users

@Michail1
Copy link

Michail1 commented Nov 7, 2018

I disagree with regards to removing it; however, I wrote that the term should be changed and/or explanation added on the popup to differentiate the wallet password from the seed encryption password.

@orogvany
Copy link
Collaborator Author

orogvany commented Nov 7, 2018

I did make them differently named on the cli to see if that clarified. I'm thinking not calling it a password, but maybe unlock key, or restore key and restore phrase

@mdodong
Copy link
Contributor

mdodong commented Nov 7, 2018

I think better to call it
seed password

That way it's clear that the password is for the mnemonic seed

@Michail1
Copy link

Michail1 commented Nov 7, 2018

agreed.
wallet password and seed password
or
wallet password and seed encryption.

@orogvany orogvany added the feature Request a new feature label Nov 8, 2018
@orogvany orogvany added this to the v1.5.0 milestone Nov 19, 2018
@semuxgo
Copy link
Contributor

semuxgo commented Jul 20, 2019

See #231

@semuxgo semuxgo closed this as completed Jul 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Request a new feature
Projects
None yet
Development

No branches or pull requests

4 participants