Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(identity): add generate commitment function #877

Merged
merged 1 commit into from
Oct 17, 2024
Merged

feat(identity): add generate commitment function #877

merged 1 commit into from
Oct 17, 2024

Conversation

vplasencia
Copy link
Member

Description

This static method is particularly useful after signature verification, as it allows retrieval of the corresponding commitment associated with the public key.

Related Issue(s)

Closes #873

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run yarn format and yarn lint without getting any errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@vplasencia
feat(identity): add generate commitment function
1286f18 
This static method is particularly useful after signature verification, as it allows retrieval of
the corresponding commitment associated with the public key.

re #873
@vplasencia vplasencia requested a review from a team as a code owner October 16, 2024 19:36
cedoor
cedoor approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@cedoor cedoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

@vplasencia vplasencia merged commit b3f8629 into main Oct 17, 2024
5 checks passed
@vplasencia vplasencia deleted the feat/generate-commitment-function branch October 17, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedoor cedoor cedoor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add function to get commitment from public key
2 participants
@vplasencia @cedoor