Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify TimeInterval restrictions #1112

Closed
dylan-sa opened this issue Jun 27, 2024 · 2 comments · Fixed by #1111
Closed

Modify TimeInterval restrictions #1112

dylan-sa opened this issue Jun 27, 2024 · 2 comments · Fixed by #1111
Assignees

Comments

@dylan-sa
Copy link
Contributor

In #925, we settled on adding actualStartDateTime and actualEndDateTime restrictions to TimeInterval. @rjyounes has pointed out that the definitions of these predicates are phrased in the past tense, making them not a good fit for future time intervals. For this reason, we have kept the restrictions out of the 13.0 release.

Assuming dateTime restrictions would be good to have on TimeInterval, one option is to modify the definitions for actualStartDateTime and actualEndDateTime to include known datetimes in the future, even if we haven't reached them yet.

@dylan-sa
Copy link
Contributor Author

Decision: use startDateTime and endDateTime predicates in the restriction instead. Update annotations for these predicates to clarify usage.

@rjyounes rjyounes moved this from In Triage to To Do in gist Version 13.0.0 Jun 27, 2024
@rjyounes
Copy link
Collaborator

DECISION:

  • Change restrictions from actual dates to endDateTime and startDateTime.
  • Modify definitions of those predicates to use present rather than past tense (e.g., "starts" rather than "started").
  • Modify/add scope notes to say that generally these will not be asserted, and possibly mention the example of TimeInterval as a case where they would be.

@rjyounes rjyounes moved this from To Do to In Progress in gist Version 13.0.0 Jun 27, 2024
@rjyounes rjyounes changed the title Add TimeInterval restrictions Modify TimeInterval restrictions Jun 27, 2024
@rjyounes rjyounes moved this from In Progress to Done in gist Version 13.0.0 Jun 28, 2024
@rjyounes rjyounes moved this from Done to In Review in gist Version 13.0.0 Jun 28, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in gist Version 13.0.0 Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
2 participants