-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration scripts for major changes in 13.0.0 #1091
Comments
@DanCarey404 is away until July 5, please consult @rjyounes, @dylan-sa, @kchastain703, or @uscholdm to see what changes, if any, can be automated. |
This would take some time to figure out what is possible and then to write the scripts. I suspect that there may be a few things that are automatable. |
Sample triples:
(Don't worry that it appears we're losing meaning here; we have added category classes which need to be instantiated by users in order to provide those semantics and more. Those triples can't be added by the scripts because we have only defined the classes; categories will have to be defined in the user's namespace.) |
@kchastain703 @uscholdm @dylan-sa @pwin Can one or more of you confirm that the address examples are correct and as complete as they can be given the shift towards user-defined categories? Thanks. |
That's mostly true, however we could provide samples indicating how it would work. Maybe not a good idea, better left to the usage documentation. |
I just confirmed that the examples are correct. |
for the first example, |
There is no
|
Each line of the exx above is meant to be read independently. The requirement is just for test triples to test the migration scripts.
I am planning to write a narrative migration doc along the lines of what Phil is doing for uoms in PR #1110. See new issue #1109. The intent was for this to have been done in addition to the model explanation in the gist-doc repo, but that is not what happened, so I will do it unless you want to volunteer. |
It is not enough to have in the usage documentation in gist-doc. Users will expect some instructions on how to migrate, they are not going to go looking there to puzzle it out. |
Oh okay, I was misinterpreting the examples, sorry. The example triple patterns look good to me. |
How is this relevant? These are example triples used to test the migration script. It makes no difference what the type of the subject is (which incidentally is not necessarily gist:Person just because of the infix, it has not been asserted). |
It was not immediately obvious to me whether the midfixes were meant to be significant and intended to be in any of the migration queries. Apparently, they are not. |
We also need to include scripts to convert to using gist:offers. Working on it. |
Phil has created migration scripts for the units and magnitudes model (PR #1071), so no need to deal with those.
Major changes requiring migration scripts:
hasCommunicationAddress
tohasAddress
. Work with Dan to see what else can be automated.Remove sensor-related terms - PR Removes sensor-related terms to fix issue 462 #1089 - no migration here, they will just have to stop using themThanks!
The text was updated successfully, but these errors were encountered: