Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create GitHub sub-module for common tools #955

Open
rjyounes opened this issue Aug 24, 2023 · 9 comments
Open

Create GitHub sub-module for common tools #955

rjyounes opened this issue Aug 24, 2023 · 9 comments
Assignees

Comments

@rjyounes
Copy link
Collaborator

rjyounes commented Aug 24, 2023

Include:

  • Pre-commit hooks
  • setup.cmd
  • rdf-toolkit.jar
  • Versioning validation
  • Other validations (e.g., from Peter)

Not:

  • bundle.yaml - this is project-specific
  • LICENSE.txt - project-specific
@rjyounes
Copy link
Collaborator Author

Also add functionality proposed in #953.

@Jamie-SA
Copy link
Contributor

Initial proposal:

  • create a new github repository, possible name: ontokit
  • move the ./tools and ./validation directories from this repo, to same directories in ontokit
  • use git submodules to have ontokit show up as the ./ontokit directory in this repo
  • move the setup.cmd script to the base directory of ontokit
  • modify the setup.cmd and pre-commit scripts to work in this configuration and automate details of submodules as much as possible

@rjyounes
Copy link
Collaborator Author

If we implement the versioning ontology in gist as in #979, we could also put the versioning queries in ontokit. If people want to modify the queries they could still create their own versions.

Could everything that's now in gist tools also reside in ontokit?

@Jamie-SA
Copy link
Contributor

Could everything that's now in gist tools also reside in ontokit?

Yes, that is my expectation.

@rjyounes
Copy link
Collaborator Author

We should also put the versioning queries into this repository.

@rjyounes rjyounes moved this to To do (typically assigned) in gist Version 12.1.0 Nov 19, 2023
@rjyounes rjyounes changed the title Put pre-commit hooks into a GitHub sub-module Create GitHub sub-module for common tools Feb 20, 2024
@rjyounes rjyounes assigned sa-bpelakh and unassigned coltonglasgow and Jamie-SA Feb 20, 2024
@rjyounes
Copy link
Collaborator Author

Repository: ontology-developer-kit

@rjyounes
Copy link
Collaborator Author

In future the sub-gists could include the gist repo if we want.

@sa-bpelakh sa-bpelakh moved this from In Triage to In Progress in gist Infrastructure Feb 20, 2024
@coltonglasgow
Copy link
Contributor

Make sure everything from ./tools and ./validation has been copied over.

Note: Validations are currently gist specific.

@rjyounes
Copy link
Collaborator Author

Make sure everything from ./tools and ./validation has been copied over.

If validations are gist-specific in the sense of referring to gist, they should not be in the sub-module. If they are gist-specific only in the sense that they use the gist style guide, then we can include them since they enforce our conventions. Anyone who doesn't want to apply those conventions doesn't have to use them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

No branches or pull requests

4 participants