Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete/deprecate gist:BuildingAddress #483

Closed
rjyounes opened this issue May 25, 2021 · 3 comments
Closed

Delete/deprecate gist:BuildingAddress #483

rjyounes opened this issue May 25, 2021 · 3 comments
Assignees
Labels
impact: major Non-backward compatible (changes inferences; e.g., adding a restriction, domain, range) status: implementation specified Implementation has been specified. A developer should be assigned. topic: addresses and locations

Comments

@rjyounes
Copy link
Collaborator

rjyounes commented May 25, 2021

A BuildingAddress is just the address of a Building - but see #482.

Another option is to rename it StreetAddress, as a subclass of PostalAddress and to differentiate it from PO Box, etc., which may have been the original intent.

Assigning to 10.0.0 release since deletion or renaming without deprecating would be a major change.

@rjyounes rjyounes added the impact: major Non-backward compatible (changes inferences; e.g., adding a restriction, domain, range) label May 25, 2021
@uscholdm
Copy link
Contributor

A BuildingAddress is just the address of a Building

Maybe not. The address itself may have different characteristics, if there was type checking, probably the SHACL for a building address would differ from other addresses.

I'm not sure one way or the other.

@rjyounes
Copy link
Collaborator Author

DECISION:

  • Remove BuildingAddress
  • Add StreetAddress as subclass of PostalAddress (definition not exclusive to buildings - can include parks, parking lots, etc.)
  • Define super-property hasAddress
  • Replace hasStreetAddress with hasPhysicalAddress (what a building, park, parking lot have)
  • Clarify definition of hasCommunicationAddress: add domain (Person U Organization) and reword definition

@rjyounes rjyounes added status: implementation specified Implementation has been specified. A developer should be assigned. and removed status: under review In triage labels Jun 24, 2021
@rjyounes rjyounes assigned sa-bpelakh and unassigned uscholdm Jun 24, 2021
@rjyounes rjyounes added status: under review In triage and removed status: implementation specified Implementation has been specified. A developer should be assigned. labels Jul 15, 2021
@rjyounes
Copy link
Collaborator Author

Moving back to 'status: in review' to deal with questions of physical/street/postal address. See discussion thread in PR #508.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact: major Non-backward compatible (changes inferences; e.g., adding a restriction, domain, range) status: implementation specified Implementation has been specified. A developer should be assigned. topic: addresses and locations
Projects
None yet
Development

No branches or pull requests

3 participants