-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make success comments filterable #360
Conversation
I know this isn't particularly helpful, but my team has been running into this as well, and would love to see this merged in. If there's anything I can do to assist, please feel free to let me know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. However I do think that documentation should be included for this filter as well.
Of course! I can do, that, if you point me to the right place. 😊 |
I'm not an official maintainer, though if I were to assume I'd go ahead and drop the |
sorry for the delay with reviewing PRs. We are all pretty swamped right now, but how to find time to review the open PRs and onboard new maintainers soon |
Any reason this is not merged? Currently I have the problem that if semantic-release with github gets added to an old repo with thousands of merged pr's, you end up with thousands of comments done by semantic-release. I wonder why this was not yet mentioned anywhere. |
So we've got a similar feature merged on the semantic-release/gitlab plugin, and more robust at that. It'd be nice if we can replicate the exact same flow here which i believe should succeed this PR. 😉 |
🎉 This issue has been resolved in version 10.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Fixes #359