Skip to content

Commit

Permalink
[rb] Enable Edge tests on RBE
Browse files Browse the repository at this point in the history
  • Loading branch information
p0deje committed Mar 15, 2024
1 parent e9bbb29 commit cb98925
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,8 @@ def chrome_options(args: [], **opts)
def edge_options(args: [], **opts)
opts[:binary] ||= ENV['EDGE_BINARY'] if ENV.key?('EDGE_BINARY')
args << '--headless=chrome' if ENV['HEADLESS']
args << '--no-sandbox'
args << '--disable-gpu'
WebDriver::Options.edge(browser_version: 'stable', args: args, **opts)
end

Expand Down
8 changes: 5 additions & 3 deletions rb/spec/tests.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,16 @@ BROWSERS = {
"edge": {
"data": edge_data,
"deps": ["//rb/lib/selenium/webdriver:edge"],
"tags": [
"skip-remote", # TODO: Add Linux version of Edge to pinned browsers.
],
"tags": [],
"target_compatible_with": [],
"env": {
"WD_REMOTE_BROWSER": "edge",
"WD_SPEC_DRIVER": "edge",
} | select({
"@selenium//common:use_pinned_linux_edge": {
"EDGE_BINARY": "$(location @linux_edge//:opt/microsoft/msedge/microsoft-edge)",
"MSEDGEDRIVER_BINARY": "$(location @linux_edgedriver//:msedgedriver)",
},
"@selenium//common:use_pinned_macos_edge": {
"EDGE_BINARY": "$(location @mac_edge//:Edge.app)/Contents/MacOS/Microsoft\\ Edge",
"MSEDGEDRIVER_BINARY": "$(location @mac_edgedriver//:msedgedriver)",
Expand Down

0 comments on commit cb98925

Please sign in to comment.