Skip to content

Commit

Permalink
[py] removed redundant attributes capabilities and set_capability
Browse files Browse the repository at this point in the history
… in wpewebkit/options.py (#12169)

* added type hints to all the methods in Select class

* fixed lynting error by moving standard import to the beginning

* fixed import formatting issue in Select class

* optimized _get_longest_token method in Select class

* added driver types to types.py

* added type hints to all conditions in expected_conditions.py

* resolved merge conflict

* moved driver types to select.py

* added driver types to expected_conditions.py

* moved driver types to expected_conditions.py

* removed driver imports to fix circular import

* fixed typo

* resolved

* removed empty line

* fixed typo

* removed duplicate import

* fixed incorrect return types for couple of conditions

* fixed lynting error by breaking different imports from typing module into different lines

* fixed lynting errors

* made formatting changes

* added type hints to all the methods in Select class

* fixed lynting error by moving standard import to the beginning

* fixed all formatting issues

* added newline after standard import in select.py

* added type hints to all conditions in expected_conditions.py

* resolved merge conflicts

* resolved merge conflicts

* made formatting changes

* fixed all formatting issues

* mapped all error codes and its corresponding exception classes to dictionary

* fixed formatting issue

* fixed error_handler_tests.py to do a dictionary lookup

* restored errorhandler.py

* restored error_handler_tests.py

* fixed typo in error_handler_test.py

* clean up

* removed redundant getter and setter method in wpewebkit/options.py

* replaced set_capability method into setter in common/options.py

* fixed typo

* added comment

* fixed lynting error

* Revert "removed redundant getter and setter method in wpewebkit/options.py"

This reverts commit 15feb5c.

* revereted the changes made to Options class

* reverted options.py

---------

Co-authored-by: Diego Molina <[email protected]>
  • Loading branch information
sandeepsuryaprasad and diemol authored Jun 8, 2023
1 parent 043bb18 commit ca9d41a
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions py/selenium/webdriver/wpewebkit/options.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,6 @@ def __init__(self) -> None:
self._binary_location = ""
self._caps = DesiredCapabilities.WPEWEBKIT.copy()

@property
def capabilities(self):
return self._caps

def set_capability(self, name, value) -> None:
"""Sets a capability."""
self._caps[name] = value

@property
def binary_location(self) -> str:
"""Returns the location of the browser binary otherwise an empty
Expand Down

0 comments on commit ca9d41a

Please sign in to comment.