Skip to content

Commit

Permalink
Fixing API mismatch in .NET ChromeOptions and rereleasing as 2.50.1
Browse files Browse the repository at this point in the history
  • Loading branch information
jimevanssfdc committed Jan 28, 2016
1 parent e212e3a commit 9078eba
Show file tree
Hide file tree
Showing 6 changed files with 29 additions and 9 deletions.
4 changes: 4 additions & 0 deletions dotnet/CHANGELOG
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
v2.50.1
=======
* Changed ChromeOptions to have correct EnableMobileEmulation API.

v2.50.0
=======
* Updated embedded Firefox driver with new click algorithm
Expand Down
4 changes: 2 additions & 2 deletions dotnet/src/core/Properties/AssemblyInfo.cs
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,5 @@
// Minor Version
// Build Number
// Revision
[assembly: AssemblyVersion("2.50.0.0")]
[assembly: AssemblyFileVersion("2.50.0.0")]
[assembly: AssemblyVersion("2.50.1.0")]
[assembly: AssemblyFileVersion("2.50.1.0")]
4 changes: 2 additions & 2 deletions dotnet/src/support/Properties/AssemblyInfo.cs
Original file line number Diff line number Diff line change
Expand Up @@ -50,5 +50,5 @@
// Minor Version
// Build Number
// Revision
[assembly: AssemblyVersion("2.50.0.0")]
[assembly: AssemblyFileVersion("2.50.0.0")]
[assembly: AssemblyVersion("2.50.1.0")]
[assembly: AssemblyFileVersion("2.50.1.0")]
18 changes: 17 additions & 1 deletion dotnet/src/webdriver/Chrome/ChromeOptions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,7 @@ public void EnableMobileEmulation(string deviceName)
/// <remarks>Specifying an invalid device name will not throw an exeption, but
/// will generate an error in Chrome when the driver starts. To unset mobile
/// emulation, call this method with <see langword="null"/> as the argument.</remarks>
public void EnableMobileDeviceEmulation(ChromeMobileEmulationDeviceSettings deviceSettings)
public void EnableMobileEmulation(ChromeMobileEmulationDeviceSettings deviceSettings)
{
this.mobileEmulationDeviceName = null;
if (deviceSettings != null && string.IsNullOrEmpty(deviceSettings.UserAgent))
Expand All @@ -423,6 +423,22 @@ public void EnableMobileDeviceEmulation(ChromeMobileEmulationDeviceSettings devi
this.mobileEmulationDeviceSettings = deviceSettings;
}

/// <summary>
/// Allows the Chrome browser to emulate a mobile device.
/// </summary>
/// <param name="deviceSettings">The <see cref="ChromeMobileEmulationDeviceSettings"/>
/// object containing the settings of the device to emulate.</param>
/// <exception cref="ArgumentException">Thrown if the device settings option does
/// not have a user agent string set.</exception>
/// <remarks>Specifying an invalid device name will not throw an exeption, but
/// will generate an error in Chrome when the driver starts. To unset mobile
/// emulation, call this method with <see langword="null"/> as the argument.</remarks>
[Obsolete("Use the EnableMobileEmulation method instead. This method was released in error, and will be removed in a future release.")]
public void EnableMobileDeviceEmulation(ChromeMobileEmulationDeviceSettings deviceSettings)
{
this.EnableMobileEmulation(deviceSettings);
}

/// <summary>
/// Adds a type of window that will be listed in the list of window handles
/// returned by the Chrome driver.
Expand Down
4 changes: 2 additions & 2 deletions dotnet/src/webdriver/Properties/AssemblyInfo.cs
Original file line number Diff line number Diff line change
Expand Up @@ -49,5 +49,5 @@
// Minor Version
// Build Number
// Revision
[assembly: AssemblyVersion("2.50.0.0")]
[assembly: AssemblyFileVersion("2.50.0.0")]
[assembly: AssemblyVersion("2.50.1.0")]
[assembly: AssemblyFileVersion("2.50.1.0")]
4 changes: 2 additions & 2 deletions dotnet/src/webdriverbackedselenium/Properties/AssemblyInfo.cs
Original file line number Diff line number Diff line change
Expand Up @@ -50,5 +50,5 @@
// Minor Version
// Build Number
// Revision
[assembly: AssemblyVersion("2.50.0.0")]
[assembly: AssemblyFileVersion("2.50.0.0")]
[assembly: AssemblyVersion("2.50.1.0")]
[assembly: AssemblyFileVersion("2.50.1.0")]

0 comments on commit 9078eba

Please sign in to comment.