[dotnet] Fix protocol cdp version for remote webdriver (#13507)

* Amend protocol cdp version for remote webdriver * Don't parse protocol version if it is specified by user
SeleniumHQ · Feb 2, 2024 · 5c214ba · 5c214ba
1 parent 249e291
commit 5c214ba
Showing 1 changed file with 20 additions and 9 deletions.
diff --git a/dotnet/src/webdriver/Remote/RemoteWebDriver.cs b/dotnet/src/webdriver/Remote/RemoteWebDriver.cs
@@ -433,25 +433,36 @@ public DevToolsSession GetDevToolsSession()
         /// <returns>The active session to use to communicate with the Developer Tools debugging protocol.</returns>
         public DevToolsSession GetDevToolsSession(DevToolsOptions options)
         {
+            if (options is null)
+            {
+                throw new ArgumentNullException(nameof(options));
+            }
+
             if (this.devToolsSession == null)
             {
                 if (!this.Capabilities.HasCapability(RemoteDevToolsEndPointCapabilityName))
                 {
                     throw new WebDriverException("Cannot find " + RemoteDevToolsEndPointCapabilityName + " capability for driver");
                 }
 
-                if (!this.Capabilities.HasCapability(RemoteDevToolsVersionCapabilityName))
-                {
-                    throw new WebDriverException("Cannot find " + RemoteDevToolsVersionCapabilityName + " capability for driver");
-                }
-
                 string debuggerAddress = this.Capabilities.GetCapability(RemoteDevToolsEndPointCapabilityName).ToString();
-                string version = this.Capabilities.GetCapability(RemoteDevToolsVersionCapabilityName).ToString();
 
-                bool versionParsed = int.TryParse(version.Substring(0, version.IndexOf(".")), out int devToolsProtocolVersion);
-                if (!versionParsed)
+                if (!options.ProtocolVersion.HasValue || options.ProtocolVersion == DevToolsSession.AutoDetectDevToolsProtocolVersion)
                 {
-                    throw new WebDriverException("Cannot parse protocol version from reported version string: " + version);
+                    if (!this.Capabilities.HasCapability(RemoteDevToolsVersionCapabilityName))
+                    {
+                        throw new WebDriverException("Cannot find " + RemoteDevToolsVersionCapabilityName + " capability for driver");
+                    }
+
+                    string version = this.Capabilities.GetCapability(RemoteDevToolsVersionCapabilityName).ToString();
+
+                    bool versionParsed = int.TryParse(version.Substring(0, version.IndexOf(".")), out int devToolsProtocolVersion);
+                    if (!versionParsed)
+                    {
+                        throw new WebDriverException("Cannot parse protocol version from reported version string: " + version);
+                    }
+
+                    options.ProtocolVersion = devToolsProtocolVersion;
                 }
 
                 try