Skip to content

Commit

Permalink
Fixing timeout issue in the Grid.
Browse files Browse the repository at this point in the history
  • Loading branch information
barancev committed Jan 19, 2016
1 parent e1c317c commit 545fba4
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ public BaseRemoteProxy(RegistrationRequest request, Registry registry) {

maxConcurrentSession = getConfigInteger(RegistrationRequest.MAX_SESSION);
cleanUpCycle = getConfigInteger(RegistrationRequest.CLEAN_UP_CYCLE);
timeOutMs = getConfigInteger(RegistrationRequest.TIME_OUT);
timeOutMs = getConfigInteger(RegistrationRequest.TIME_OUT) * 1000;
statusCheckTimeout = getConfigInteger(RegistrationRequest.STATUS_CHECK_TIMEOUT);

List<DesiredCapabilities> capabilities = request.getCapabilities();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1022,6 +1022,8 @@ public static RemoteControlConfiguration parseLauncherOptions(String[] args) {
configuration.setDebugURL(getArg(args, ++i));
} else if ("-timeout".equalsIgnoreCase(arg)) {
configuration.setTimeoutInSeconds(Integer.parseInt(getArg(args, ++i)));
} else if ("-browserTimeout".equalsIgnoreCase(arg)) {
configuration.setBrowserTimeoutInMs(Integer.parseInt(getArg(args, ++i)));

This comment has been minimized.

Copy link
@harriswong

harriswong Jan 26, 2016

When I run -h on the standalone server, it says:

> java -jar selenium-server-standalone-2.49.1.jar -role hub -h
...
 -browserTimeout:
    The timeout in seconds a browser can hang
> java -jar selenium-server-standalone-2.49.1.jar -role node -h
...
 -browserTimeout:
    The timeout in seconds a browser can hang

However, this line looks like it is setting browser timeout in ms instead, is this intended?

This comment has been minimized.

Copy link
@barancev

barancev Jan 26, 2016

Author Member

SeleniumServer is neither 'hub' nor 'node', it's legacy RC server and it should have no this option. I've added it by mistake, it should be removed.

} else if ("-jettyThreads".equalsIgnoreCase(arg)) {
int jettyThreadsCount = Integer.parseInt(getArg(args, ++i));

Expand Down

0 comments on commit 545fba4

Please sign in to comment.