Docker: Node env vars to disable/enable VNC view only, password (#2489)

Signed-off-by: Viet Nguyen Duc <[email protected]>

NodeBase/start-vnc.sh

@@ -14,15 +14,15 @@ if [ "${START_XVFB:-$SE_START_XVFB}" = true ]; then
       fi
     done
     VNC_NO_PASSWORD=${VNC_NO_PASSWORD:-$SE_VNC_NO_PASSWORD}
-    if [ ! -z $VNC_NO_PASSWORD ]; then
+    if [ "${VNC_NO_PASSWORD}" = "true" ] || [ "${VNC_NO_PASSWORD}" = "1" ]; then
       echo "Starting VNC server without password authentication"
       X11VNC_OPTS=
     else
       X11VNC_OPTS=-usepw
     fi
 
     VNC_VIEW_ONLY=${VNC_VIEW_ONLY:-$SE_VNC_VIEW_ONLY}
-    if [ ! -z $VNC_VIEW_ONLY ]; then
+    if [ "${VNC_VIEW_ONLY}" = "true" ] || [ "${VNC_VIEW_ONLY}" = "1" ]; then
       echo "Starting VNC server with viewonly option"
       X11VNC_OPTS="${X11VNC_OPTS} -viewonly"
     fi

README.md

@@ -1661,9 +1661,9 @@ Then, you would use in your VNC client:
 If you get a prompt asking for a password, it is: `secret`. If you wish to change this, 
 you can set the environment variable `SE_VNC_PASSWORD`.
 
-If you want to run VNC without password authentication you can set the environment variable `SE_VNC_NO_PASSWORD=1`.
+If you want to run VNC without password authentication you can set the environment variable `SE_VNC_NO_PASSWORD=true`.
 
-If you want to run VNC in view-only mode you can set the environment variable `SE_VNC_VIEW_ONLY=1`.
+If you want to run VNC in view-only mode you can set the environment variable `SE_VNC_VIEW_ONLY=true`.
 
 If you want to modify the open file descriptor limit for the VNC server process you can set the environment variable `SE_VNC_ULIMIT=4096`.