Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalization term initialized temperamentally #68

Open
EoghanTotten opened this issue Feb 7, 2019 · 2 comments
Open

Normalization term initialized temperamentally #68

EoghanTotten opened this issue Feb 7, 2019 · 2 comments

Comments

@EoghanTotten
Copy link

https://github.com/seismology/mc_kernel/blob/master/src/kernel.f90#L435-L460

I noticed when compiling mc_kernel on my local machine, the following warning for kernel.f90:

'Extension: Unary operator following arithmetic operator (use parentheses) at (1)
Warning: ‘normalization_term’ may be used uninitialized in this function [-Wmaybe-uninitialized]'.

By placing brackets around each of the four -1.d0 terms in the above lines (e.g. calc_misfit_kernel(itrace) = this%integrate_parseval( timeseries_cut, this%seis_velo_cut_fd) &
* this%normalization * (-1.d0)) , this warning goes away.

@sstaehler
Copy link
Member

in the source code you describe a different compile error. Which one is the correct one? Does it change results?

@EoghanTotten
Copy link
Author

Hi @sstaehler , I think my comments in source code are just sloppy language: it is the same compile WARNING, rather than error but seemed to change results in a positive manner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants