From b4190aaad6259ec208ef872c2bda4a55eb7afb45 Mon Sep 17 00:00:00 2001
From: codchen <codchen03@gmail.com>
Date: Tue, 27 Feb 2024 08:57:36 +0800
Subject: [PATCH] Fix debug log (#205)

---
 internal/consensus/reactor.go      | 11 ++++++++++-
 internal/consensus/reactor_test.go |  2 ++
 node/node.go                       |  1 +
 3 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/internal/consensus/reactor.go b/internal/consensus/reactor.go
index 3631fd1d8..3ceadae90 100644
--- a/internal/consensus/reactor.go
+++ b/internal/consensus/reactor.go
@@ -8,6 +8,7 @@ import (
 	"sync"
 	"time"
 
+	"github.com/tendermint/tendermint/config"
 	cstypes "github.com/tendermint/tendermint/internal/consensus/types"
 	"github.com/tendermint/tendermint/internal/eventbus"
 	"github.com/tendermint/tendermint/internal/p2p"
@@ -121,6 +122,7 @@ type ConsSyncReactor interface {
 type Reactor struct {
 	service.BaseService
 	logger log.Logger
+	cfg    *config.Config
 
 	state    *State
 	eventBus *eventbus.EventBus
@@ -148,6 +150,7 @@ func NewReactor(
 	eventBus *eventbus.EventBus,
 	waitSync bool,
 	metrics *Metrics,
+	cfg *config.Config,
 ) *Reactor {
 	r := &Reactor{
 		logger:      logger,
@@ -160,6 +163,7 @@ func NewReactor(
 		peerEvents:  peerEvents,
 		readySignal: make(chan struct{}),
 		channels:    &channelBundle{},
+		cfg:         cfg,
 	}
 	r.BaseService = *service.NewBaseService(logger, "Consensus", r)
 
@@ -646,7 +650,12 @@ func (r *Reactor) pickSendVote(ctx context.Context, ps *PeerState, votes types.V
 		return false, nil
 	}
 
-	r.logger.Debug("sending vote message", "ps", ps, "vote", vote)
+	if r.cfg.BaseConfig.LogLevel == log.LogLevelDebug {
+		psJson, err := ps.ToJSON() // expensive, so we only want to call if debug is on
+		if err != nil {
+			r.logger.Debug("sending vote message", "ps", string(psJson), "vote", vote)
+		}
+	}
 	if err := voteCh.Send(ctx, p2p.Envelope{
 		To: ps.peerID,
 		Message: &tmcons.Vote{
diff --git a/internal/consensus/reactor_test.go b/internal/consensus/reactor_test.go
index 8d840a14f..97927b235 100644
--- a/internal/consensus/reactor_test.go
+++ b/internal/consensus/reactor_test.go
@@ -97,6 +97,7 @@ func setup(
 			state.eventBus,
 			true,
 			NopMetrics(),
+			config.DefaultConfig(),
 		)
 
 		reactor.SetStateChannel(rts.stateChannels[nodeID])
@@ -697,6 +698,7 @@ func TestSwitchToConsensusVoteExtensions(t *testing.T) {
 				cs.eventBus,
 				true,
 				NopMetrics(),
+				config.DefaultConfig(),
 			)
 
 			if testCase.shouldPanic {
diff --git a/node/node.go b/node/node.go
index 0cd8a62bf..d3075434e 100644
--- a/node/node.go
+++ b/node/node.go
@@ -349,6 +349,7 @@ func makeNode(
 		eventBus,
 		waitSync,
 		nodeMetrics.consensus,
+		cfg,
 	)
 
 	node.router.AddChDescToBeAdded(consensus.GetStateChannelDescriptor(), csReactor.SetStateChannel)