Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default diffusion constants should be in layout, not parameters #38

Open
jeremymchacon opened this issue Oct 29, 2020 · 0 comments
Open

Comments

@jeremymchacon
Copy link
Contributor

Hey,

I think something that would improve intuition about where certain parameters are would be to remove default diffusion constants from the parameters files and instead have them as part of the layout. Especially because if we ever have non-default values (e.g. specific to only one metabolite), these specifics are defined in the layout. Therefore, it makes sense to have the default there.

Alternatively, we could "hide" these defaults in the python and matlab toolboxes, so that from a user's perspective it all appears to happen in the layout even if that is not true in the written comets files. I'd prefer the first option though. Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant