Skip to content
This repository has been archived by the owner on Aug 22, 2023. It is now read-only.

.end() called twice error on latest superagent #24

Open
yocontra opened this issue Jan 9, 2017 · 7 comments
Open

.end() called twice error on latest superagent #24

yocontra opened this issue Jan 9, 2017 · 7 comments

Comments

@yocontra
Copy link

yocontra commented Jan 9, 2017

When a retry happens:

Warning: .end() was called twice. This is not supported in superagent

@seokgyo
Copy link

seokgyo commented Jan 23, 2017

FYI. ladjs/superagent#1155

@FlorianWendelborn
Copy link

@seokgyo Does this mean that this project is now useless?

@yocontra
Copy link
Author

I think this project still has a place - the ability to configure the retry policy is important. Worth fixing.

@brugnara
Copy link

Hi there. Our common friend TJ solved, at least for me, with this simple trick:

in.pipe(out, { end: false })

Source: ladjs/superagent#94 (comment)

@yocontra
Copy link
Author

@brugnara Different issue entirely

@tt-mikeolson
Copy link

The native superagent.retry() method is now documented here: http://visionmedia.github.io/superagent/#retrying-requests

@rifflock
Copy link

Wouldn't it make more sense to use the built-in retry functionality in superagent?
If users want to customize the retry functionality it would be easy enough to write a PR to the superagent repo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants