Fails to check ftp URLs with username and password

[codelion]

I was trying to test this library with GramTest, a grammar based test case generation tool (https://github.com/codelion/gramtest). I found that it fails to to check ftp URLs.

isUrl('ftp://username:password@hostname') //returns false

[ghost]

Sorry but the code actually returns true:

https://runkit.com/embed/bpdqcu0ec4nk

[davisjam]

@codelion The current behavior is to return true on the example you provided.

Can you confirm and close this issue, or suggest another failing ftp example?

[codelion]

@davisjam @chmursonss I updated the URL, I think it fails for FTP URLs with username and password.

[villesau]

@codelion it's because your url is ftp://username:password@hostname. It succeeds if you have any TLD there: ftp://username:[email protected]

[codelion]

@villesau as per the RFC https://www.ietf.org/rfc/rfc1738.txt host name doesn’t have to end with a TLD.

hostname = *[ domainlabel "." ] toplabel
domainlabel = alphadigit | alphadigit *[ alphadigit | "-" ] alphadigit
toplabel = alpha | alpha *[ alphadigit | "-" ] alphadigit

[riker09]

This seems to be an invalid URL: amqp://user:[email protected]:1234

The port is what throws the regex off, the rest matches just fine.

[sloops77]

I also get this failure for a url like 'postgresql://user:pass@localhost:5432/dev'. without a user/pass it passes