Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not install library without node overrides #1044

Closed
broksonic21 opened this issue Feb 27, 2024 · 5 comments
Closed

Can not install library without node overrides #1044

broksonic21 opened this issue Feb 27, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@broksonic21
Copy link

See : segmentio/tsub-js#45 which is the cause

Current tsub dependency (

"@segment/tsub": "^2.0.0",
) is dependent on stdlib-js/math-base-special-ldexp @ ^0.0.5 which is buggy installing (on Mac's at least) due to node-gyp

See #818 for more as well

If you could bump that to support 0.2.1 it works fine. We do it via overrides right now, but npm and overrides cause other issues so be good to mainline this.

npm ERR! path /node_modules/@stdlib/number-float64-base-normalize
npm ERR! command failed
npm ERR! command sh -c node-gyp rebuild
npm ERR! gyp info it worked if it ends with ok
npm ERR! gyp info using [email protected]
npm ERR! gyp info using [email protected] | darwin | x64
.........
.........
.........
npm ERR! gyp info spawn args ]
npm ERR! gyp: binding.gyp not found (cwd: /node_modules/@stdlib/number-float64-base-normalize) while trying to load binding.gyp
npm ERR! gyp ERR! configure error 
npm ERR! gyp ERR! stack Error: `gyp` failed with exit code: 1
npm ERR! gyp ERR! stack     at ChildProcess.onCpExit (/Users/.n/lib/node_modules/npm/node_modules/node-gyp/lib/configure.js:325:16)
npm ERR! gyp ERR! stack     at ChildProcess.emit (node:events:513:28)
npm ERR! gyp ERR! stack     at ChildProcess._handle.onexit (node:internal/child_process:291:12)
npm ERR! gyp ERR! System Darwin 22.3.0
npm ERR! gyp ERR! command "/Users/.n/bin/node" "/Users/.n/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
npm ERR! gyp ERR! cwd /node_modules/@stdlib/number-float64-base-normalize
npm ERR! gyp ERR! node -v v18.15.0
npm ERR! gyp ERR! node-gyp -v v9.3.1
npm ERR! gyp ERR! not ok

I also get this with node 20 and node-gyp 10

@silesky silesky added the bug Something isn't working label Mar 14, 2024
@feimosi
Copy link

feimosi commented Mar 19, 2024

@broksonic21 can you please share the exact overrides that worked for you?

@pkarl
Copy link

pkarl commented Apr 4, 2024

@broksonic21 can you please share the exact overrides that worked for you?

in the linked thread it can be worked around w/out an override by installing npm i @stdlib/[email protected] --save-dev --save-exact

@broksonic21
Copy link
Author

Yep, that's what we are doing - installing 0.0.8 explicitly and avoiding overrides (since npm overrides are super buggy)

npm i @stdlib/[email protected] --save-dev --save-exact

@broksonic21
Copy link
Author

broksonic21 commented May 7, 2024

Segment team: any chance to get a fix in on this?

@silesky as this blocks any standard install, not just our use case - can you help get this on radar?

@silesky
Copy link
Contributor

silesky commented Jul 15, 2024

Fixed in 1.72.0

@silesky silesky closed this as completed Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants