Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SFMC] Add Multistatus Support for SFMC #2639

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

harsh-joshi99
Copy link
Contributor

@harsh-joshi99 harsh-joshi99 commented Dec 12, 2024

This PR adds multistatus response dataExtension and contactDataExtension actions of SFMC.

JIRA -> https://segment.atlassian.net/browse/STRATCONN-5312

Testing

Testing completed successfully in local via integrations.
Testing completed successfully in staging via sneakerhead.
Testing Document.

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 86.95652% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.42%. Comparing base (bb253f2) to head (484b19b).
Report is 30 commits behind head on main.

Files with missing lines Patch % Lines
...ions/salesforce-marketing-cloud/sfmc-operations.ts 86.95% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2639      +/-   ##
==========================================
- Coverage   78.58%   78.42%   -0.17%     
==========================================
  Files        1030     1030              
  Lines       18184    18385     +201     
  Branches     3431     3481      +50     
==========================================
+ Hits        14290    14418     +128     
- Misses       2752     2806      +54     
- Partials     1142     1161      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@harsh-joshi99 harsh-joshi99 marked this pull request as ready for review December 13, 2024 05:42
@harsh-joshi99 harsh-joshi99 requested a review from a team as a code owner December 13, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants