Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit statuses for unir should not trigger merges #14

Closed
seemethere opened this issue Apr 2, 2018 · 0 comments
Closed

Commit statuses for unir should not trigger merges #14

seemethere opened this issue Apr 2, 2018 · 0 comments
Assignees
@seemethere
Labels
bug

Comments

@seemethere
Copy link
Owner

With the inclusion of #12 we should not have commit statuses trigger a successful merge scenario since this would cause a double merge scenario as seen in:

unir_1   | time="2018-04-02T22:11:16Z" level=info msg="Agreement reached! Merging https://github.com/seemethere/unir/pull/13"
unir_1   | time="2018-04-02T22:11:17Z" level=info msg="Merge successful for https://github.com/seemethere/unir/pull/13"
unir_1   | time="2018-04-02T22:11:18Z" level=info msg="Agreement reached! Merging https://github.com/seemethere/unir/pull/13"
unir_1   | time="2018-04-02T22:11:19Z" level=error msg="Merge failed for https://github.com/seemethere/unir/pull/13: , PUT https://api.github.com/repos/seemethere/unir/pulls/13/merge: 405 Pull Request is not mergeable []"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seemethere seemethere

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@seemethere