Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments on Workflow RO Crate spec #183

Open
fbacall opened this issue Mar 6, 2020 · 7 comments
Open

Comments on Workflow RO Crate spec #183

fbacall opened this issue Mar 6, 2020 · 7 comments

Comments

@fbacall
Copy link
Contributor

fbacall commented Mar 6, 2020

https://github.com/workflowhub-eu/about/wiki/Workflow-RO-Crate

Please leave any comments here

@stain
Copy link
Collaborator

stain commented Mar 17, 2020

It was somewhat agreed to move that document to the wiki https://github.com/workflowhub-eu/about/wiki/Workflow-RO-Crate

@stuzart
Copy link
Member

stuzart commented Mar 17, 2020

The relationship with the BioSchemaWorkflow specification (also being developed) isn't explicitly mentioned, and may be unclear to anybody unfamiliar with it.

@jmfernandez
Copy link

Hi, I'm missing an example of a workflow with a subjectOf, showing both an abstract CWL workflow and a concrete implementation (CWL, Nextflow, etc...)

@jmfernandez
Copy link

Also, I'm missing some mention about whether the input, output and parameter names of the abstract CWL and concrete implementation workflows should match. I guess the the inputs and outputs in abstract CWL are going to have the needed ontological annotations (for instance, from EDAM), as it is not assured the concrete implementation workflow format is able to document it properly.

@jmfernandez
Copy link

Last, some workflows in the wild usually include some accessory / optional initialization tasks to download and/or format reference databases, in order to work properly. Should the spec document that?

@stain
Copy link
Collaborator

stain commented Nov 3, 2020

"license" is given as a string (SPDX identifer?), but both https://www.researchobject.org/ro-crate/1.1/contextual-entities.html#licensing-access-control-and-copyright and https://schema.org/license says it should be a URL, meaning {"@id": "https://spdx.org/licenses/MIT"} or similar.

If this list of license identifiers are SPDX then the full URL should be better.

@ptsefton
Copy link

It is not clear at the top of the document whether this is intended to be generic -- I am assuming you can use this and NOT do the workflow-hub specific part. Can this be made clear?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants