Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

template: node 16 #633

Merged
merged 4 commits into from
Oct 28, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/famous-zebras-shop.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"skuba": patch
---

template: Bump non-Lambda templates to Node.js 16

Node.js 16 is now in active LTS. The Lambda templates are stuck on Node.js 14 until the new AWS Lambda runtime is released.
2 changes: 1 addition & 1 deletion template/express-rest-api/.nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
14
16
2 changes: 1 addition & 1 deletion template/express-rest-api/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ RUN yarn build

###

FROM gcr.io/distroless/nodejs:14 AS runtime
FROM gcr.io/distroless/nodejs:16 AS runtime

WORKDIR /workdir

Expand Down
2 changes: 1 addition & 1 deletion template/express-rest-api/Dockerfile.dev-deps
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# syntax=docker/dockerfile:1.2

FROM node:14-alpine AS dev-deps
FROM node:16-alpine AS dev-deps

WORKDIR /workdir

Expand Down
4 changes: 2 additions & 2 deletions template/express-rest-api/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,14 @@
},
"devDependencies": {
"@types/express": "^4.17.13",
"@types/node": "^14.17.27",
"@types/node": "^16.0.0",
"@types/supertest": "^2.0.11",
"pino-pretty": "^7.1.0",
"skuba": "*",
"supertest": "^6.1.6"
},
"engines": {
"node": ">=14"
"node": ">=16"
},
"license": "UNLICENSED",
"private": true,
Expand Down
2 changes: 1 addition & 1 deletion template/greeter/.nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
14
16
2 changes: 1 addition & 1 deletion template/greeter/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# syntax=docker/dockerfile:1.2

FROM node:14-alpine AS dev-deps
FROM node:16-alpine AS dev-deps

WORKDIR /workdir

Expand Down
4 changes: 2 additions & 2 deletions template/greeter/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@
"skuba-dive": "^1.2.0"
},
"devDependencies": {
"@types/node": "^14.17.9",
"@types/node": "^16.0.0",
"skuba": "*"
},
"engines": {
"node": ">=14"
"node": ">=16"
},
"license": "UNLICENSED",
"private": true,
Expand Down
2 changes: 1 addition & 1 deletion template/koa-rest-api/.nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
14
16
2 changes: 1 addition & 1 deletion template/koa-rest-api/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ RUN yarn build

###

FROM gcr.io/distroless/nodejs:14 AS runtime
FROM gcr.io/distroless/nodejs:16 AS runtime

WORKDIR /workdir

Expand Down
2 changes: 1 addition & 1 deletion template/koa-rest-api/Dockerfile.dev-deps
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# syntax=docker/dockerfile:1.2

FROM node:14-alpine AS dev-deps
FROM node:16-alpine AS dev-deps

WORKDIR /workdir

Expand Down
4 changes: 2 additions & 2 deletions template/koa-rest-api/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"@types/koa": "^2.13.4",
"@types/koa-bodyparser": "^5.0.2",
"@types/koa__router": "^8.0.8",
"@types/node": "^14.17.27",
"@types/node": "^16.0.0",
"@types/supertest": "^2.0.11",
"@types/uuid": "^8.3.1",
"chance": "^1.1.8",
Expand All @@ -27,7 +27,7 @@
"supertest": "^6.1.6"
},
"engines": {
"node": ">=14"
"node": ">=16"
},
"license": "UNLICENSED",
"private": true,
Expand Down
2 changes: 1 addition & 1 deletion template/lambda-sqs-worker-cdk/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"@aws-cdk/aws-sqs": "^1.118.0",
"@aws-cdk/core": "^1.118.0",
"@types/aws-lambda": "^8.10.82",
"@types/node": "^14.17.9",
"@types/node": "^14.0.0",
"aws-cdk": "^1.118.0",
"skuba": "*"
},
Expand Down
2 changes: 1 addition & 1 deletion template/lambda-sqs-worker/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"devDependencies": {
"@types/aws-lambda": "^8.10.84",
"@types/chance": "^1.1.3",
"@types/node": "^14.17.27",
"@types/node": "^14.0.0",
"chance": "^1.1.8",
"pino-pretty": "^7.1.0",
"serverless": "^2.63.0",
Expand Down
4 changes: 2 additions & 2 deletions template/oss-npm-package/.github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ jobs:
fetch-depth: 0
lfs: true

- name: Set up Node.js 14.x
- name: Set up Node.js 16.x
uses: actions/setup-node@master
with:
node-version: 14.x
node-version: 16.x

- name: Install dependencies
run: yarn install --frozen-lockfile
Expand Down
4 changes: 2 additions & 2 deletions template/oss-npm-package/.github/workflows/validate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ jobs:
with:
lfs: true

- name: Set up Node.js 14.x
- name: Set up Node.js 16.x
uses: actions/setup-node@master
with:
node-version: 14.x
node-version: 16.x

- name: Install dependencies
run: yarn install --frozen-lockfile
Expand Down
2 changes: 1 addition & 1 deletion template/oss-npm-package/.nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
14
16
2 changes: 1 addition & 1 deletion template/oss-npm-package/_package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"dependencies": {},
"description": "<%- description %>",
"devDependencies": {
"@types/node": "^14.17.9",
"@types/node": "^16.0.0",
"commitizen": "^4.2.4",
"skuba": "*"
},
Expand Down
2 changes: 1 addition & 1 deletion template/private-npm-package/.nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
14
16
2 changes: 1 addition & 1 deletion template/private-npm-package/_package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"dependencies": {},
"description": "<%- description %>",
"devDependencies": {
"@types/node": "^14.17.9",
"@types/node": "^16.0.0",
"commitizen": "^4.2.4",
"skuba": "*"
},
Expand Down