-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run ESLint and Prettier linting in worker threads #548
Merged
Commits on Sep 21, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 296d225 - Browse repository at this point
Copy the full SHA 296d225View commit details -
Run ESLint and Prettier formatting in process
This took an eternity because I went down a rabbit hole of parallelising Prettier and had little to show for it based on very rudimentary benchmarking of skuba itself; it seemed the overhead of spinning up multiple worker processes was significant. I may give this another shot with worker threads in future. While this is undeniably more code that using the ESLint and Prettier CLIs out of the box, it presents a few opportunities: - Customising logging output, particularly for `--debug`ging. - Taking the above point further: supporting Buildkite annotations, particularly when `lint`ing. - A marginally faster execution and smaller resource footprint. - Likelier compatibility with alternative module resolution approaches like Yarn PnP, which can make it harder to reliably locate other `.bin` tools when `exec`ing.
Configuration menu - View commit details
-
Copy full SHA for ed7e6c9 - Browse repository at this point
Copy the full SHA ed7e6c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 943ae62 - Browse repository at this point
Copy the full SHA 943ae62View commit details -
Configuration menu - View commit details
-
Copy full SHA for c33da9c - Browse repository at this point
Copy the full SHA c33da9cView commit details
Commits on Sep 22, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 8423cde - Browse repository at this point
Copy the full SHA 8423cdeView commit details -
Recommend
yarn link
for local integrationWhile this doesn't perform global linkage like `npm link`, its setup is almost instantaneous compared to an arduous install process with the npm command.
Configuration menu - View commit details
-
Copy full SHA for cefc549 - Browse repository at this point
Copy the full SHA cefc549View commit details -
Configuration menu - View commit details
-
Copy full SHA for a912cd3 - Browse repository at this point
Copy the full SHA a912cd3View commit details -
Configuration menu - View commit details
-
Copy full SHA for f194811 - Browse repository at this point
Copy the full SHA f194811View commit details -
Configuration menu - View commit details
-
Copy full SHA for c950660 - Browse repository at this point
Copy the full SHA c950660View commit details -
Configuration menu - View commit details
-
Copy full SHA for 10e7578 - Browse repository at this point
Copy the full SHA 10e7578View commit details -
Configuration menu - View commit details
-
Copy full SHA for 468200f - Browse repository at this point
Copy the full SHA 468200fView commit details -
Configuration menu - View commit details
-
Copy full SHA for b68850a - Browse repository at this point
Copy the full SHA b68850aView commit details
Commits on Sep 23, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 7ddfc06 - Browse repository at this point
Copy the full SHA 7ddfc06View commit details -
Configuration menu - View commit details
-
Copy full SHA for cd5c77f - Browse repository at this point
Copy the full SHA cd5c77fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 72dc802 - Browse repository at this point
Copy the full SHA 72dc802View commit details -
Configuration menu - View commit details
-
Copy full SHA for 035f470 - Browse repository at this point
Copy the full SHA 035f470View commit details -
Configuration menu - View commit details
-
Copy full SHA for e0c46b0 - Browse repository at this point
Copy the full SHA e0c46b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 37256ba - Browse repository at this point
Copy the full SHA 37256baView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2cb9e61 - Browse repository at this point
Copy the full SHA 2cb9e61View commit details -
Configuration menu - View commit details
-
Copy full SHA for cdc5943 - Browse repository at this point
Copy the full SHA cdc5943View commit details -
Avoid experimental
fs.promises.cp
`fs-extra` is back, but only in `devDependencies`.
Configuration menu - View commit details
-
Copy full SHA for db25721 - Browse repository at this point
Copy the full SHA db25721View commit details -
Configuration menu - View commit details
-
Copy full SHA for 830469e - Browse repository at this point
Copy the full SHA 830469eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d45137 - Browse repository at this point
Copy the full SHA 5d45137View commit details -
Configuration menu - View commit details
-
Copy full SHA for e8af956 - Browse repository at this point
Copy the full SHA e8af956View commit details -
Configuration menu - View commit details
-
Copy full SHA for e576007 - Browse repository at this point
Copy the full SHA e576007View commit details -
We'd rather get feedback on a snapshot diff first.
Configuration menu - View commit details
-
Copy full SHA for 3282788 - Browse repository at this point
Copy the full SHA 3282788View commit details -
Configuration menu - View commit details
-
Copy full SHA for 346bcd3 - Browse repository at this point
Copy the full SHA 346bcd3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 72b8bc0 - Browse repository at this point
Copy the full SHA 72b8bc0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 92d0b6f - Browse repository at this point
Copy the full SHA 92d0b6fView commit details -
Configuration menu - View commit details
-
Copy full SHA for e84c504 - Browse repository at this point
Copy the full SHA e84c504View commit details -
Configuration menu - View commit details
-
Copy full SHA for 759df52 - Browse repository at this point
Copy the full SHA 759df52View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b80124 - Browse repository at this point
Copy the full SHA 7b80124View commit details -
Configuration menu - View commit details
-
Copy full SHA for 054ed69 - Browse repository at this point
Copy the full SHA 054ed69View commit details
Commits on Sep 24, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 091ef99 - Browse repository at this point
Copy the full SHA 091ef99View commit details -
Configuration menu - View commit details
-
Copy full SHA for fc514e2 - Browse repository at this point
Copy the full SHA fc514e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 39c759f - Browse repository at this point
Copy the full SHA 39c759fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 241bcdf - Browse repository at this point
Copy the full SHA 241bcdfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4303e2e - Browse repository at this point
Copy the full SHA 4303e2eView commit details -
Configuration menu - View commit details
-
Copy full SHA for a8d1fef - Browse repository at this point
Copy the full SHA a8d1fefView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9df026a - Browse repository at this point
Copy the full SHA 9df026aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 16adeb9 - Browse repository at this point
Copy the full SHA 16adeb9View commit details -
Configuration menu - View commit details
-
Copy full SHA for cc561a0 - Browse repository at this point
Copy the full SHA cc561a0View commit details -
De-confuse some worker functions
Co-authored-by: Ryan Cumming <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 79a6b6e - Browse repository at this point
Copy the full SHA 79a6b6eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.