Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run ESLint and Prettier linting in worker threads #548

Merged
merged 43 commits into from
Sep 24, 2021
Merged

Commits on Sep 21, 2021

  1. Configuration menu
    Copy the full SHA
    296d225 View commit details
    Browse the repository at this point in the history
  2. Run ESLint and Prettier formatting in process

    This took an eternity because I went down a rabbit hole of parallelising
    Prettier and had little to show for it based on very rudimentary
    benchmarking of skuba itself; it seemed the overhead of spinning up
    multiple worker processes was significant. I may give this another shot
    with worker threads in future.
    
    While this is undeniably more code that using the ESLint and Prettier
    CLIs out of the box, it presents a few opportunities:
    
    - Customising logging output, particularly for `--debug`ging.
    - Taking the above point further: supporting Buildkite annotations,
      particularly when `lint`ing.
    - A marginally faster execution and smaller resource footprint.
    - Likelier compatibility with alternative module resolution approaches
      like Yarn PnP, which can make it harder to reliably locate other
      `.bin` tools when `exec`ing.
    72636c committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    ed7e6c9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    943ae62 View commit details
    Browse the repository at this point in the history
  4. Fix bad merge

    72636c authored Sep 21, 2021
    Configuration menu
    Copy the full SHA
    c33da9c View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2021

  1. Configuration menu
    Copy the full SHA
    8423cde View commit details
    Browse the repository at this point in the history
  2. Recommend yarn link for local integration

    While this doesn't perform global linkage like `npm link`, its setup is
    almost instantaneous compared to an arduous install process with the npm
    command.
    72636c committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    cefc549 View commit details
    Browse the repository at this point in the history
  3. Log elapsed timing information

    72636c committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    a912cd3 View commit details
    Browse the repository at this point in the history
  4. Write Prettified output

    72636c committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    f194811 View commit details
    Browse the repository at this point in the history
  5. Add TODO for ESLint caching

    72636c committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    c950660 View commit details
    Browse the repository at this point in the history
  6. Improve logging output further

    72636c committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    10e7578 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    468200f View commit details
    Browse the repository at this point in the history
  8. Update doco

    72636c committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    b68850a View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2021

  1. Configuration menu
    Copy the full SHA
    7ddfc06 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cd5c77f View commit details
    Browse the repository at this point in the history
  3. Update slimy-cars-wash.md

    72636c authored Sep 23, 2021
    Configuration menu
    Copy the full SHA
    72dc802 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    035f470 View commit details
    Browse the repository at this point in the history
  5. Revert Buildkite spoiler

    72636c committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    e0c46b0 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    37256ba View commit details
    Browse the repository at this point in the history
  7. Test format command

    72636c committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    2cb9e61 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    cdc5943 View commit details
    Browse the repository at this point in the history
  9. Avoid experimental fs.promises.cp

    `fs-extra` is back, but only in `devDependencies`.
    72636c committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    db25721 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    830469e View commit details
    Browse the repository at this point in the history
  11. Restore original cwd

    72636c committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    5d45137 View commit details
    Browse the repository at this point in the history
  12. Remove spoiler again

    72636c committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    e8af956 View commit details
    Browse the repository at this point in the history
  13. Clean up logging snapshot

    72636c committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    e576007 View commit details
    Browse the repository at this point in the history
  14. Check exit code last

    We'd rather get feedback on a snapshot diff first.
    72636c committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    3282788 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    346bcd3 View commit details
    Browse the repository at this point in the history
  16. Support serial execution

    72636c committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    72b8bc0 View commit details
    Browse the repository at this point in the history
  17. Prettify

    72636c committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    92d0b6f View commit details
    Browse the repository at this point in the history
  18. Split up files further

    72636c committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    e84c504 View commit details
    Browse the repository at this point in the history
  19. Tidy some changesets

    72636c committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    759df52 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    7b80124 View commit details
    Browse the repository at this point in the history
  21. Remove sleep hack

    This doesn't seem to be necessary anymore.
    72636c authored Sep 23, 2021
    Configuration menu
    Copy the full SHA
    054ed69 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2021

  1. Configuration menu
    Copy the full SHA
    091ef99 View commit details
    Browse the repository at this point in the history
  2. Fix bad fs-extra merge

    72636c committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    fc514e2 View commit details
    Browse the repository at this point in the history
  3. Rebase lint snapshots

    72636c committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    39c759f View commit details
    Browse the repository at this point in the history
  4. Restore comment from bad merge

    72636c committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    241bcdf View commit details
    Browse the repository at this point in the history
  5. Reformat changesets

    72636c committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    4303e2e View commit details
    Browse the repository at this point in the history
  6. Rebase snapshot

    72636c committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    a8d1fef View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    9df026a View commit details
    Browse the repository at this point in the history
  8. Align newlining in format

    72636c committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    16adeb9 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    cc561a0 View commit details
    Browse the repository at this point in the history
  10. De-confuse some worker functions

    Co-authored-by: Ryan Cumming <[email protected]>
    72636c and etaoins committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    79a6b6e View commit details
    Browse the repository at this point in the history