Fix process.argv propagation
#341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`skuba node` and `skuba start` weren't even making an attempt to propagate command-line arguments to `process.argv` in the underlying entry point script. This is a dealbreaker for the former command as it's fairly common to want to run arbitrary scripts that take arguments, e.g. `skuba node cli/dropAllTables.ts --force`. To maintain compatibility some tricky parsing is required, because we currently route arguments to a bunch of different places. The wrapper interplay is somewhat simplified by moving some arguments to environment variables. I also uncovered that `ts-node` doesn't like Node.js inspector options, so we now run scripts using plain `node`. What could go wrong with all these layers upon layers?
🦋 Changeset detectedLatest commit: 13eea0a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tobyhei
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skuba nodeandskuba startweren't even making an attempt to propagate command-line arguments toprocess.argvin the underlying entry point script. This is a dealbreaker for the former command as it's fairly common to want to run arbitrary scripts that take arguments, e.g.skuba node cli/dropAllTables.ts --force.To maintain compatibility some tricky parsing is required, because we currently route arguments to a bunch of different places. The wrapper interplay is somewhat simplified by moving some arguments to environment variables.
I also uncovered that
ts-nodedoesn't like Node.js inspector options, so we now run scripts using plainnode. What could go wrong with all these layers upon layers?