Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init: Run Prettier after templating #1337

Merged
merged 23 commits into from
Dec 13, 2023
Merged

init: Run Prettier after templating #1337

merged 23 commits into from
Dec 13, 2023

Conversation

72636c
Copy link
Member

@72636c 72636c commented Dec 12, 2023

This Markdown table is not pretty after templating, but we swallowed the command failure in the test-template script:

| <%- defaultBranch %> | latest |

This Markdown table is not pretty after templating, but we swallowed the
command failure in the `test-template` script:

https://github.com/seek-oss/skuba/blob/83ccc1bd424222570373cac19dc38b69646d8785/template/oss-npm-package/README.md?plain=1#L115
Copy link

changeset-bot bot commented Dec 12, 2023

🦋 Changeset detected

Latest commit: 5a52bea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
skuba Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@72636c 72636c marked this pull request as ready for review December 13, 2023 01:41
@72636c 72636c requested review from a team as code owners December 13, 2023 01:41
@72636c 72636c changed the title Format on init init: Run Prettier after templating Dec 13, 2023
@72636c 72636c merged commit 347b0bc into master Dec 13, 2023
19 checks passed
@72636c 72636c deleted the init-format branch December 13, 2023 04:56
@seek-oss-ci seek-oss-ci mentioned this pull request Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants