Use connection reuse environment variable in Lambda #130
Conversation
🦋 Changeset is good to goLatest commit: 5ce871a We got this. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -3,7 +3,6 @@ import { Agent } from 'https'; | |||
| import { SNS } from 'aws-sdk'; | |||
|
|
|||
| const agent = new Agent({ | |||
There was a problem hiding this comment.
I think we can get rid of the custom agent entirely 🙂
| @@ -59,6 +59,7 @@ functions: | |||
| reservedConcurrency: 20 | |||
| timeout: 30 | |||
| environment: | |||
| AWS_NODEJS_CONNECTION_REUSE_ENABLED: 1 | |||
There was a problem hiding this comment.
Ooh awesome! It would be nice to include this and also have links to the relevant doco for both environment variables, as part of documenting more of the rationale behind these templates
There was a problem hiding this comment.
@tobyhei any reasoning behind not adding that?
There was a problem hiding this comment.
Oh sorry, I was just going to suggest we add AWS_STS_REGIONAL_ENDPOINTS=regional but then thought it was scope creep for this PR so removed the comment
Replaces
keepAliveproperty of https agent