Disable noUnusedLocals and noUnusedParameters in tsconfig #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skuba is already using Seek's ESLint config which has https://eslint.org/docs/latest/rules/no-unused-vars which works for both function and types We don't need both tools to do the same thing.
🦋 Changeset detectedLatest commit: 0fbe5bc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
72636c
reviewed
May 29, 2023
There was a problem hiding this comment.
Thanks for the PR @eddeee888! Would it make sense to update https://github.com/seek-oss/tsconfig-seek/blob/0aa686106e7a2a3d9c7e420b88d208932126d58d/tsconfig.json#L34-L35 instead?
There was a problem hiding this comment.
There was a problem hiding this comment.
Happy to go either way though
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
noUnusedLocalsandnoUnusedParametersfalse.These two values are set as
truein SEEK's tsconfig.Skuba is already using Seek's ESLint config which has a rule which works for both function and types.
We do not need both tools to do the same thing. ESLint has better support for ignoring files if needed.