Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

progress key wrongly set in cdk.json #796

Closed
bosonseek opened this issue Mar 21, 2022 · 2 comments · Fixed by #797
Closed

progress key wrongly set in cdk.json #796

bosonseek opened this issue Mar 21, 2022 · 2 comments · Fixed by #797

Comments

@bosonseek
Copy link
Contributor

bosonseek commented Mar 21, 2022

Issue:

in the lambda-sqs-worker-cdk template, the progress key was set under context

{
  "app": "npx ts-node infra/index.ts",
  "context": {
    ...,
    "progress": "events"
  }
}

Suggestion:

the progress key should be in the upper level:

{
  "app": "npx ts-node infra/index.ts",
  "context": {
    ...
  },
  "progress": "events"
}

if we update the cdk.json, we can remove the --progress events from the package.json.

Reference: aws-cdk master branch v2.30

Edit: similar issue reported

@72636c
Copy link
Member

72636c commented Mar 21, 2022

🤦 good pick up. Would you be keen to contribute a patch @bosonseek?

@bosonseek
Copy link
Contributor Author

Hey @72636c , I don't have access to the OSS repo. Can you add me in. Don't wanna fork it :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants