Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Koa template fails lint on init #64

Closed
72636c opened this issue Jun 18, 2020 · 0 comments · Fixed by #70
Closed

Koa template fails lint on init #64

72636c opened this issue Jun 18, 2020 · 0 comments · Fixed by #70

Comments

@72636c
Copy link
Member

72636c commented Jun 18, 2020

We're careful with our templating of the Gantry environment names because they could contain characters like - that are not valid in JavaScript dot notation:

...configs['<%- prodGantryEnvironmentName %>'](),

The unfortunate side effect is that simple environment names fail initial lint because they should use dot notation:

[ESLint  ] .../src/config.ts
[ESLint  ]   45:16  error  ["prod"] is better written in dot notation  dot-notation
[ESLint  ]
[ESLint  ] ✖ 1 problem (1 error, 0 warnings)
[ESLint  ]   1 error and 0 warnings potentially fixable with the `--fix` option.
72636c added a commit that referenced this issue Jun 18, 2020
Resolves #64. This is now validated in CI.
72636c added a commit that referenced this issue Jun 18, 2020
Resolves #64. This is now validated in CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant