Creating a custom template with .png file breaks BYO templates

[relientm96]

Description

I was trying to create a template with image/.png files in the README, but came across this error:

I assume that there is a <% somewhere in the raw version of the .png file but it isn't ignored by skuba when running skuba configure

I also realised that it does not run pnpm install neither does it also initialise your project as a git repository. So I think the configure step just fails.

[AaronMoat]

Is the raw file safe to attach here in OSS @relientm96?

[relientm96]

Is the raw file safe to attach here in OSS @relientm96?

Yeap the file is safe to be shared but unsure how to share the actual raw contents

Here is a link to the repo that I was trying to skuba configure that has the image: https://github.com/SEEK-Jobs/ap-2024-worker-template/blob/master/images/image.png

[AaronMoat]

Yep:

$ cat Downloads/image.png | grep '<%'
Binary file (standard input) matches

[relientm96]

Yep:

$ cat Downloads/image.png | grep '<%'
Binary file (standard input) matches

Ahh should have though of that, thanks for checking @AaronMoat 😆

[AaronMoat]

Any thoughts on resolution? Skip the templating if it's in an exclusion list of file formats? Or perhaps inclusion list?

[relientm96]

Any thoughts on resolution? Skip the templating if it's in an exclusion list of file formats? Or perhaps inclusion list?

Some sort of exclusion input on skuba-configure would be great as users of skuba would assume everything is included for now.