Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-skuba-template-js should pass on template repos #1379

Open
72636c opened this issue Jan 9, 2024 · 0 comments
Open

no-skuba-template-js should pass on template repos #1379

72636c opened this issue Jan 9, 2024 · 0 comments

Comments

@72636c
Copy link
Member

72636c commented Jan 9, 2024

This is a bit embarrassing but I think the skuba.template.js internal lint rule fails on actual template repos:

const templateConfigPath = path.join(
path.dirname(manifest.path),
'skuba.template.js',
);
if (await pathExists(templateConfigPath)) {
logger.err(
`Template is incomplete; run ${logger.bold(
packageManager.exec,
'skuba',
'configure',
)}. ${logger.dim('no-skuba-template-js')}`,
);

Some options to resolve this after we land #1370 may include:

  1. We add some property to the skuba.template.js during skuba init which differentiates the templated file from the original template, then check for that
  2. Heuristics around the repository name and whether package.json#/skuba exists (no need for it to on a template repo)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant