Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propose skuba.config.ts #1168

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Propose skuba.config.ts #1168

wants to merge 1 commit into from

Conversation

72636c
Copy link
Member

@72636c 72636c commented May 9, 2023

Steals from sku and ESLint's recent direction. Follows on from #1163 and resolves #1167.

@changeset-bot
Copy link

changeset-bot bot commented May 9, 2023

⚠️ No Changeset found

Latest commit: dd4db49

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

mrm007
mrm007 reviewed May 11, 2023
View reviewed changes
src/config/load.ts

const configPath = path.join(manifest.path, '..', CONFIG_FILENAME);

const esbuildRegistration = register({ target: 'node16' });
Copy link
Contributor

@mrm007 mrm007 May 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth having a hot reloading ability when the config changes, e.g. restart the server started with skuba start or anything like that.

For reference, we do this in Crackle:
https://github.com/seek-oss/crackle/blob/49b48ee405477cccdc1d6e7bbbb4c26b921c7760/packages/cli/src/index.ts#L33-L44
https://github.com/seek-oss/crackle/blob/560489afdadda7f8b3985f0639ae55f83815875e/packages/core/src/entries/resolve-config.ts#L25

@tadhglewis tadhglewis added the dino:snooze Snooze in Review Dino label Jul 27, 2023
@tadhglewis
Copy link
Member

Any update on whether we're going ahead with these changes? Let's snooze this for now otherwise

@AaronMoat AaronMoat mentioned this pull request Oct 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrm007 mrm007 mrm007 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
dino:snooze Snooze in Review Dino
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add skuba.config.ts
3 participants
@72636c @tadhglewis @mrm007