Disable noUnusedLocals and noUnusedParameters in tsconfig (#1181)

* Make noUnusedLocals and noUnusedParameters false Skuba is already using Seek's ESLint config which has https://eslint.org/docs/latest/rules/no-unused-vars which works for both function and types We don't need both tools to do the same thing. * Add changeset * Tweak changeset --------- Co-authored-by: Ryan Ling <[email protected]>
seek-oss · May 29, 2023 · b1d8e80 · b1d8e80
1 parent 3e4dfbb
commit b1d8e80
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/.changeset/forty-hornets-argue.md b/.changeset/forty-hornets-argue.md
@@ -0,0 +1,7 @@
+---
+'skuba': patch
+---
+
+tsconfig: Turn off [`noUnusedLocals`](https://www.typescriptlang.org/tsconfig#noUnusedLocals) and [`noUnusedParameters`](https://www.typescriptlang.org/tsconfig#noUnusedParameters)
+
+[SEEK's ESLint config](https://github.com/seek-oss/eslint-config-seek) has a [rule](https://eslint.org/docs/latest/rules/no-unused-vars) which works for both function and types. We do not need both tools to do the same thing and ESLint has better support for ignoring files if needed.
diff --git a/config/tsconfig.json b/config/tsconfig.json
@@ -3,7 +3,9 @@
     "incremental": true,
     "isolatedModules": true,
     "moduleResolution": "node",
-    "resolveJsonModule": true
+    "resolveJsonModule": true,
+    "noUnusedLocals": false,
+    "noUnusedParameters": false
   },
   "extends": "tsconfig-seek"
 }