feat(globals): Add Cypress support #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.eslintrc.js
Outdated
| ENV: true, | ||
| after: true, | ||
| before: true, | ||
| browser: true, |
There was a problem hiding this comment.
What are your thoughts on browser given this config is used on node projects too. Should we add a separate node profile that sets this to false?
There was a problem hiding this comment.
Usually it's one config for the whole project though, not sure if we want to start splitting it and creating extra setup for that 🤔
michaeltaranto
previously approved these changes
Jan 9, 2019
michaeltaranto
dismissed
their stale review
Might be able to make this list a cypress only list, given our env settings...
|
Maybe this PR should pivot to adding cypress support using eslint-plugin-cypress? |
kosanna
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
ENVandbrowserglobals are no longer supported and should be added where applicable as a project config. For webdriveriobrowserusewebdriverioplugin