Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command line start up options and flags don't work correctly from the packaged binaries #17

Closed
sedwards2009 opened this issue Mar 23, 2016 · 3 comments

Comments

@sedwards2009
Copy link
Owner

Starting up extraterm from a binary zip download and passing in some flags and options (e.g. --cygwinDir) doesn't parse the options correctly.

The problem is in the commander module which Extraterm uses to parse command line arguments. It assumes that the first two items in process.argv are the nodejs executable and then the name of script being executed. This assumption is violated when starting up the packaged version of Extraterm.

A workaround is to pass an extra dummy value before the first flag or option. i.e. extraterm.exe XXX --cygwinDir c:/foo

@sedwards2009 sedwards2009 changed the title Start up options and flags don't work correctly from the zip binaries Command line start up options and flags don't work correctly from the packaged binaries Mar 23, 2016
@sedwards2009
Copy link
Owner Author

See issue tj/commander.js#512

@sedwards2009
Copy link
Owner Author

Fixed in b08eeab

@tympanix
Copy link

I would assume this is a quick fix? I would love to see a universal solution that not only works with Electron but in general. You mention in #512 having two parse functions. I would like to give that a +1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants