Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests and CI for import-linter #81

Closed
skarzi opened this issue Aug 2, 2020 · 6 comments
Closed

tests and CI for import-linter #81

skarzi opened this issue Aug 2, 2020 · 6 comments

Comments

@skarzi
Copy link
Contributor

skarzi commented Aug 2, 2020

I am opening this issue to talk about CI and testing approach in this great package. We can start from discussing following points:

  1. Why travis is not fully integrated with project? Usually CI systems use github's checks to give info about build result etc which is really handy - example of github checks with travis
  2. What do you say for migrating from travis to github actions and workflows?
  3. Is tox really needed? Maybe travis build matrix or github workflows strategy matrix will be enough?
  4. What do you think about services like codecov? It's free for open source projects and can help us to get 100% code coverage and then keep it as this level
@seddonym
Copy link
Owner

seddonym commented Aug 8, 2020

Hi Łukasz,

Thanks for getting involved, and the PR!

Very much open to the improvements you mention - however changing everything comes with a time cost to review and understand the new processes - and I'm not feeling much pain with the current ones. However, if it helps others feel more able to contribute then that's worthwhile - I just might not be able to review things promptly.

Responding to each:

  1. Why travis is not fully integrated with project?

It should already be integrated with the checks that appear on the main 'conversation' tab of the PR - just not with the Github checks tab (which I haven't used elsewhere).

  1. What do you say for migrating from travis to github actions and workflows?

I don't feel strongly.

  1. Is tox really needed? Maybe travis build matrix or github workflows strategy matrix will be enough?

Yes possibly, again I don't feel strongly.

  1. What do you think about services like codecov?

I think it's great, and have used it on other projects.

@skarzi
Copy link
Contributor Author

skarzi commented Dec 23, 2020

Maybe let's start from introducing codecov to the project, what do you think?

@seddonym
Copy link
Owner

Sure! Happy to review a PR. Thanks Łukasz!

@Czaki
Copy link

Czaki commented May 4, 2021

I suggest staying with tox. It simplifies local testing.

@jakub-borusewicz
Copy link

Would be great to add mypy check to CI with quite strict configuration (and appropriate typing), it would make contributions a lot easier :)

@seddonym
Copy link
Owner

seddonym commented Feb 3, 2023

I'm going to close this ticket as we have now migrated to Github actions. Feel free to open individual tickets for the other suggestions.

@seddonym seddonym closed this as completed Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants