-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests and CI for import-linter
#81
Comments
Hi Łukasz, Thanks for getting involved, and the PR! Very much open to the improvements you mention - however changing everything comes with a time cost to review and understand the new processes - and I'm not feeling much pain with the current ones. However, if it helps others feel more able to contribute then that's worthwhile - I just might not be able to review things promptly. Responding to each:
It should already be integrated with the checks that appear on the main 'conversation' tab of the PR - just not with the Github checks tab (which I haven't used elsewhere).
I don't feel strongly.
Yes possibly, again I don't feel strongly.
I think it's great, and have used it on other projects. |
Maybe let's start from introducing |
Sure! Happy to review a PR. Thanks Łukasz! |
I suggest staying with tox. It simplifies local testing. |
Would be great to add mypy check to CI with quite strict configuration (and appropriate typing), it would make contributions a lot easier :) |
I'm going to close this ticket as we have now migrated to Github actions. Feel free to open individual tickets for the other suggestions. |
I am opening this issue to talk about CI and testing approach in this great package. We can start from discussing following points:
travis
to github actions and workflows?tox
really needed? Maybe travis build matrix or github workflows strategy matrix will be enough?The text was updated successfully, but these errors were encountered: