Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit tests use tas pipeline #244

Closed
wants to merge 1 commit into from
Closed

Conversation

miyunari
Copy link

This PR should run the Cosign unit tests with the Konflux pipeline.
I used these PRs as examples and guidelines:
securesign/trillian#197
securesign/fulcio#175
securesign/gitsign#145

jira: https://issues.redhat.com/browse/SECURESIGN-1295

@miyunari miyunari requested review from bouskaJ and JasonPowr August 27, 2024 09:11
@miyunari miyunari self-assigned this Aug 27, 2024
Copy link

openshift-ci bot commented Aug 27, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: miyunari

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@miyunari miyunari force-pushed the unit_tests_on_tas_pipeline branch from 64660d1 to 77dfa91 Compare August 27, 2024 09:25
@JasonPowr
Copy link

You need to update the cosign on-push and pull to use the new task, eg: https://github.com/securesign/gitsign/blob/main/.tekton/gitsign-pull-request.yaml#L366-L375

@miyunari miyunari force-pushed the unit_tests_on_tas_pipeline branch from 77dfa91 to f78bb1e Compare August 27, 2024 09:56
@miyunari
Copy link
Author

You need to update the cosign on-push and pull to use the new task, eg: https://github.com/securesign/gitsign/blob/main/.tekton/gitsign-pull-request.yaml#L366-L375

Ok ty, I added it - and hopefully in the correct way - could you check again @JasonPowr ? :)

@miyunari
Copy link
Author

@JasonPowr I hope I addressed all of the points you suggested in the right way? I am also super unsure if I chose the right quay images... :/ Do you know why the tests are still failing or what else could be wrong? Thanks for your help already 🤗

@miyunari miyunari requested a review from JasonPowr August 27, 2024 10:12
@JasonPowr
Copy link

@miyunari The review comments I just made should help to resolve the pipelines not running :),

@miyunari
Copy link
Author

miyunari commented Aug 27, 2024

@miyunari The review comments I just made should help to resolve the pipelines not running :),

Thanks a lot for all of your help @JasonPowr ! It seems the pipeline needs a lot of time to run, is that normal? And two of the Konflux steps already failed - https://github.com/securesign/cosign/pull/244/checks?check_run_id=29302067611

@JasonPowr
Copy link

@miyunari Sometimes when there is a lot of load on the konflux servers it can act strange i.e taking ages for a pipeline to run, The ones that have run I am seeing a failure in the unit tests for cosign eg https://console.redhat.com/application-pipeline/workspaces/rhtas/applications/cli/pipelineruns/client-server-cg-on-pull-request-fqcws

And no worries :) happy to help

@JasonPowr
Copy link

/retest

.tekton/client-server-re-pull-request.yaml Outdated Show resolved Hide resolved
.tekton/client-server-pull-request.yaml Outdated Show resolved Hide resolved
.tekton/cosign-unit-test.yaml Show resolved Hide resolved
@miyunari miyunari force-pushed the unit_tests_on_tas_pipeline branch from 9072f12 to 1109a43 Compare August 28, 2024 10:16
Signed-off-by: Janine Olear <[email protected]>
@miyunari miyunari force-pushed the unit_tests_on_tas_pipeline branch from e1b736a to 4fef38c Compare August 29, 2024 08:23
@miyunari miyunari closed this Aug 29, 2024
@miyunari miyunari reopened this Aug 29, 2024
@miyunari miyunari closed this Aug 29, 2024
@miyunari miyunari deleted the unit_tests_on_tas_pipeline branch August 29, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants