Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accept Signature in verify_signature() #360

Closed
jku opened this issue May 28, 2021 · 2 comments
Closed

accept Signature in verify_signature() #360

jku opened this issue May 28, 2021 · 2 comments

Comments

@jku
Copy link
Collaborator

jku commented May 28, 2021

A signature object was added into SSLib but verify_signature() wasn't updated to accept it.
It leads to weird code:

if not sslib_keys.verify_signature(
    sslib_key,
    signature.to_dict(), # <- why am I serializing the signature here ?
    data,
):
    print ("oh no")
@lukpueh
Copy link
Member

lukpueh commented Feb 10, 2023

I think we can change this into a "refactor internals of new signer API"-issue. cc @jku

@jku
Copy link
Collaborator Author

jku commented Feb 10, 2023

Yes I think I'm also fine with closing this... If the signer module provides me with everything I as a user need, I don't really care how the keys module operates.

@lukpueh lukpueh closed this as not planned Won't fix, can't repro, duplicate, stale Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants