Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WasteManagement sections removing issue #35

Open
Rayn2402 opened this issue Feb 3, 2020 · 0 comments
Open

WasteManagement sections removing issue #35

Rayn2402 opened this issue Feb 3, 2020 · 0 comments

Comments

@Rayn2402
Copy link

Rayn2402 commented Feb 3, 2020

While using SkylineBlWm I had an issue with guillotine.py

In function self._add_rect we can see the following lines (187-189) :

# Remove section, split and store results
self._sections.remove(section)
self._split(section, width, height)

Which remove the concerned section and then execute the split.

However, self._split function can sometimes call self._split_horizontal which has the following lines of code (66-69) :

 # First remove the section we are splitting so it doesn't 
 # interfere when later we try to merge the resulting split
 # rectangles, with the rest of free sections.
 self._sections.remove(section)

When this situation occurs, self._section tries to remove a section that has already ben removed earlier and we get an error.

This line should probably be deleted from self._split_horizontal

Thank you!

@Rayn2402 Rayn2402 changed the title WasteManagement sections removing issues WasteManagement sections removing issue Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant