Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agm-data-layer [style] is falling back to default styles on any change in the geojson #1930

Open
wajeehmisbahkhan opened this issue Feb 3, 2021 · 8 comments
Labels

Comments

@wajeehmisbahkhan
Copy link

Issue description
This may be part of a bigger problem but when my data layer changes depending on the Firestore stream, the fill color became light black and the strokes become black and become thicker which I assume are all the default styles.

Steps to reproduce and a minimal demo of the problem
I've reproduced it based on setInterval instead of a live stream of data:
https://stackblitz.com/edit/angular-google-maps-demo-ubxsif?file=app/app.component.ts
The invertColor works fine in the constructor outside of the setInterval but after the map has loaded, it no longer works.

Current behavior
It changes the styles to the default settings.

Expected/desired behavior
It should change the style to the new GeoJson.

angular-google-maps, Angular, & any other relevant dependency versions
Mentioned in the package.json

@madispold
Copy link

Did you find a solution? Facing the same issue after updating to 3.0.0

@wajeehmisbahkhan
Copy link
Author

Sadly no. And judging by the last commit date along with the fact that there is no response to any recent issues, there will probably be no fixes any time soon 😔

@LunaSquee
Copy link

LunaSquee commented May 6, 2021

It seems like this change: 7982bfb#diff-dcb9184e08ceacdb593fbaa4cac3b2d9e1546b351be15c86e6dc1b7627b35d51L271
broke this feature. If you use the old code, it works.

The state of this PR #1182 was working.

@stale
Copy link

stale bot commented Aug 21, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 21, 2021
@LunaSquee
Copy link

Still an issue, do not close this

@stale stale bot removed the stale label Aug 22, 2021
@stale
Copy link

stale bot commented Jan 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 9, 2022
@LunaSquee
Copy link

This project is obviously abandoned, I need to see about migrating to something else soon

@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants