Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change FixtureDir to testdata #10

Closed
xorcare opened this issue Mar 4, 2019 · 1 comment
Closed

Change FixtureDir to testdata #10

xorcare opened this issue Mar 4, 2019 · 1 comment
Assignees
Milestone

Comments

@xorcare
Copy link
Contributor

xorcare commented Mar 4, 2019

By default, this package uses the directory FixtureDir = "fixtures" , but in Go common practice of using the name testdata I would like to see that you have in the package by default used the dir name testdata

Examples in standard library
https://github.com/golang/go/tree/master/src/cmd/gofmt/testdata
https://github.com/golang/go/tree/master/src/encoding/json/testdata

P. S. For backward compatibility, you need to share version tags for v1.0.0 and v2.0.0 to current users of the library have not received problems.

@sebdah
Copy link
Owner

sebdah commented Oct 19, 2019

@gtrevg Thanks for implementing this. It has just now been merged to master with the v2.0.0 release.

@sebdah sebdah closed this as completed Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants