Update GH actions/checkout to v4 (#431)

* sync naming and versioning with Jint
sebastienros · Jan 27, 2024 · 144ed66 · 144ed66
1 parent f61074b
commit 144ed66
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 10 deletions.
diff --git a/.github/workflows/staging.yml → .github/workflows/build.yml b/.github/workflows/staging.yml → .github/workflows/build.yml
@@ -1,4 +1,4 @@
-name: Publish on MyGet
+name: Build
 
 on:
 
@@ -18,7 +18,7 @@ jobs:
 
     steps:
     - name: Checkout source code
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
 
     - name: Generate test cases
       working-directory: ./test/Esprima.Tests.Test262
@@ -28,7 +28,7 @@ jobs:
       run: dotnet test --configuration Release --logger GitHubActions
 
     - name: Pack with dotnet
-      run: dotnet pack src/Esprima/Esprima.csproj --output artifacts --configuration Release -p:PackageVersion=3.0.0-preview-$GITHUB_RUN_NUMBER
+      run: dotnet pack src/Esprima/Esprima.csproj --output artifacts --configuration Release -p:VersionSuffix=preview-$GITHUB_RUN_NUMBER
 
     - name: Push with dotnet
       run: dotnet nuget push artifacts/*.nupkg --api-key ${{ secrets.MYGET_API_KEY }} --skip-duplicate --source https://www.myget.org/F/esprimadotnet/api/v2/package
diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml
@@ -1,4 +1,4 @@
-name: Build
+name: PR Check
 
 on:
 
@@ -18,7 +18,7 @@ jobs:
 
     steps:
     - name: Checkout source code
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
 
     - name: Generate test cases
       working-directory: ./test/Esprima.Tests.Test262
@@ -35,7 +35,7 @@ jobs:
 
     steps:
     - name: Checkout source code
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
 
     - name: Generate test cases
       working-directory: ./test/Esprima.Tests.Test262

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -1,4 +1,4 @@
-name: Publish on NuGet
+name: Release
 
 on:
   push:
@@ -15,7 +15,7 @@ jobs:
 
     steps:
     - name: Checkout source code
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
 
     - name: Generate test cases
       working-directory: ./test/Esprima.Tests.Test262

diff --git a/src/Esprima/Esprima.csproj b/src/Esprima/Esprima.csproj
@@ -4,15 +4,18 @@
     <AssemblyName>Esprima</AssemblyName>
     <AssemblyTitle>Esprima .NET</AssemblyTitle>
     <NeutralLanguage>en-US</NeutralLanguage>
-    <BuildNumber Condition="'$(BuildNumber)' == ''">0</BuildNumber>
     <TargetFrameworks>net462;netstandard2.0;netstandard2.1</TargetFrameworks>
     <AssemblyOriginatorKeyFile>../Esprima.snk</AssemblyOriginatorKeyFile>
     <SignAssembly>true</SignAssembly>
     <PackageId>Esprima</PackageId>
     <PackageTags>javascript, parser, ecmascript</PackageTags>
     <PackageProjectUrl>https://github.com/sebastienros/esprima-dotnet</PackageProjectUrl>
     <PackageLicenseExpression>BSD-3-Clause</PackageLicenseExpression>
-    <Version>3.0.0-beta-$(BuildNumber)</Version>
+
+    <BuildNumber Condition="'$(BuildNumber)' == ''">0</BuildNumber>
+    <VersionPrefix>3.0.5</VersionPrefix>
+    <VersionSuffix>beta-$(BuildNumber)</VersionSuffix>
+    <FileVersion>$(VersionPrefix).$(BuildNumber)</FileVersion>
 
     <!-- SkipLocalsInit -->
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>