Move printing of test suite loader related warnings from TestSuite to…

… TestRunner
sebastianbergmann · Mar 31, 2020 · 10da552 · 10da552
1 parent 9331b00
commit 10da552
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 9 deletions.
diff --git a/src/Framework/TestSuite.php b/src/Framework/TestSuite.php
@@ -566,15 +566,6 @@ public function run(TestResult $result = null): TestResult
             return $result;
         }
 
-        if (\count($this->warnings) !== 0) {
-            echo \implode(
-                \PHP_EOL,
-                \array_unique($this->warnings)
-            ),
-            \PHP_EOL,
-            \PHP_EOL;
-        }
-
         /** @psalm-var class-string $className */
         $className   = $this->name;
         $hookMethods = TestUtil::getHookMethods($className);
@@ -780,6 +771,19 @@ public function injectFilter(Factory $filter): void
         }
     }
 
+    public function hasWarnings(): bool
+    {
+        return !empty($this->warnings);
+    }
+
+    public function warningsAsString(): string
+    {
+        return \implode(
+            \PHP_EOL,
+            \array_unique($this->warnings)
+        );
+    }
+
     /**
      * Creates a default TestResult object.
      */

diff --git a/src/TextUI/TestRunner.php b/src/TextUI/TestRunner.php
@@ -638,6 +638,10 @@ public function run(Test $suite, array $arguments = [], bool $exit = true): Test
             }
         }
 
+        if ($suite->hasWarnings()) {
+            $this->write($suite->warningsAsString() . \PHP_EOL . \PHP_EOL);
+        }
+
         $suite->run($result);
 
         foreach ($this->extensions as $extension) {