Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetching latest #20

Merged
merged 28 commits into from
Oct 20, 2024
Merged
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
341743c
feat: Update SQL Server API - `avm/res/sql/server` (#3325)
peterbud Oct 13, 2024
797475c
fix: Added `Microsoft.DevOpsInfrastructure/pools` to removal order (#…
AlexanderSehr Oct 13, 2024
2e27126
feat: Add new ptn modules `avm/ptn/azd/ml-ai-environment` (#3262)
Menghua1 Oct 14, 2024
b420117
fix: Aligned AKS interface to AVM specs & added UDT (#3506)
AlexanderSehr Oct 14, 2024
11fce93
feat: ACR Availability Zone Spec. (#3548)
tsc-buddy Oct 14, 2024
cab8eda
fix: Add support for CI secret (#3507)
hundredacres Oct 14, 2024
d484057
fix: Trigger AZD AKS publishing (#3512)
AlexanderSehr Oct 14, 2024
7869942
fix: AZD ML Project - Adjusted KeyVault access policies deployment (#…
AlexanderSehr Oct 14, 2024
7e97126
feat: `avm/res/db-for-postgre-sql/flexible-server` Add PEs in public …
donheerschap Oct 14, 2024
ecaa2fa
fix: Added DependsOn to Virtual Network module to prevent Network pee…
joerygrolleman Oct 14, 2024
b673ec8
fix: Added enforced location for ML-services (#3552)
AlexanderSehr Oct 14, 2024
dc6d10f
feat: module `avm/res/network/virtual-network-gateway` (#3324)
fabmas Oct 14, 2024
1c3d76b
feat: Updated RBAC schema to latest for ServerFarm (#3520)
AlexanderSehr Oct 14, 2024
f44015a
feat: Updated CognitiveServices PE implementation to latest schema (#…
AlexanderSehr Oct 14, 2024
6074f32
fix: Key Vault - Incorrect test value (#3398)
AlexanderSehr Oct 15, 2024
f850625
fix: Databricks - Aligned PE test with latest schema (#3399)
AlexanderSehr Oct 15, 2024
0b236a5
feat: Add security compliance options for `avm/res/databricks/workspa…
clintgrove Oct 15, 2024
55ee2c8
fix: bump vnet version for sub-vending (#3561)
sebassem Oct 15, 2024
6fd1411
feat: Removed explicit 'latest' pwsh installation for `Set-Environmen…
AlexanderSehr Oct 15, 2024
da7e5cb
feat: New utility module - AVM Common Types (#3397)
AlexanderSehr Oct 15, 2024
b7299ed
fix: Common-Types - Fixed workflow configuration (#3563)
AlexanderSehr Oct 16, 2024
1fe9ce0
Replaced union with shallow merge (#3564)
AlexanderSehr Oct 16, 2024
644e64f
fix: AutomationAccount - Credential et al (#3496)
AlexanderSehr Oct 16, 2024
530ee21
ci: Update psrule.yml nonsensitive param list (#3587)
eriqua Oct 17, 2024
6736202
fix: Update `avm/res/document-db/database-account` (#3565)
seesharprun Oct 17, 2024
a116415
fix: Virtual-Network-Subnet - Updated NetworkPolicy AllowdSets (#3590)
AlexanderSehr Oct 18, 2024
062177d
feat: MDFC updates on App Service (#3498)
tsc-buddy Oct 20, 2024
65a03f8
feat: `avm/ptn/data/private-analytical-workspace` V0.1 (#3307)
jbinko Oct 20, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: Databricks - Aligned PE test with latest schema (Azure#3399)
…be pulled into readme

## Description

- Aligned PE test with latest schema 
- Aligned code slightly to allow roles to be pulled into readme

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.res.databricks.workspace](https://github.com/Azure/bicep-registry-modules/actions/workflows/avm.res.databricks.workspace.yml/badge.svg?branch=users%2Falsehr%2FdatabricksPEFix&event=workflow_dispatch)](https://github.com/Azure/bicep-registry-modules/actions/workflows/avm.res.databricks.workspace.yml)
|

## Type of Change

<!-- Use the checkboxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utilities (Non-module affecting
changes)
- [ ] Azure Verified Module updates:
- [x] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation
AlexanderSehr authored Oct 15, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit f85062550a0129c69042deb80f3f056781173406
50 changes: 39 additions & 11 deletions avm/res/databricks/workspace/README.md
Original file line number Diff line number Diff line change
@@ -584,9 +584,13 @@ module workspace 'br/public:avm/res/databricks/workspace:<version>' = {
prepareEncryption: true
privateEndpoints: [
{
privateDnsZoneResourceIds: [
'<privateDNSZoneResourceId>'
]
privateDnsZoneGroup: {
privateDnsZoneGroupConfigs: [
{
privateDnsZoneResourceId: '<privateDnsZoneResourceId>'
}
]
}
service: 'databricks_ui_api'
subnetResourceId: '<subnetResourceId>'
tags: {
@@ -724,9 +728,13 @@ module workspace 'br/public:avm/res/databricks/workspace:<version>' = {
"privateEndpoints": {
"value": [
{
"privateDnsZoneResourceIds": [
"<privateDNSZoneResourceId>"
],
"privateDnsZoneGroup": {
"privateDnsZoneGroupConfigs": [
{
"privateDnsZoneResourceId": "<privateDnsZoneResourceId>"
}
]
},
"service": "databricks_ui_api",
"subnetResourceId": "<subnetResourceId>",
"tags": {
@@ -850,9 +858,13 @@ param natGatewayName = 'nat-gateway'
param prepareEncryption = true
param privateEndpoints = [
{
privateDnsZoneResourceIds: [
'<privateDNSZoneResourceId>'
]
privateDnsZoneGroup: {
privateDnsZoneGroupConfigs: [
{
privateDnsZoneResourceId: '<privateDnsZoneResourceId>'
}
]
}
service: 'databricks_ui_api'
subnetResourceId: '<subnetResourceId>'
tags: {
@@ -1635,6 +1647,17 @@ Array of role assignments to create.

- Required: No
- Type: array
- Roles configurable by name:
- `'Contributor'`
- `'DNS Resolver Contributor'`
- `'DNS Zone Contributor'`
- `'Domain Services Contributor'`
- `'Domain Services Reader'`
- `'Network Contributor'`
- `'Owner'`
- `'Private DNS Zone Contributor'`
- `'Reader'`
- `'Role Based Access Control Administrator (Preview)'`

**Required parameters**

@@ -2221,10 +2244,15 @@ Array of role assignments to create.
- Type: array
- Roles configurable by name:
- `'Contributor'`
- `'DNS Resolver Contributor'`
- `'DNS Zone Contributor'`
- `'Domain Services Contributor'`
- `'Domain Services Reader'`
- `'Network Contributor'`
- `'Owner'`
- `'Private DNS Zone Contributor'`
- `'Reader'`
- `'Role Based Access Control Administrator'`
- `'User Access Administrator'`
- `'Role Based Access Control Administrator (Preview)'`

**Required parameters**

12 changes: 6 additions & 6 deletions avm/res/databricks/workspace/main.bicep
Original file line number Diff line number Diff line change
@@ -455,7 +455,7 @@ var _storageAccountId = resourceId(
)

@batchSize(1)
module storageAccount_privateEndpoints 'br/public:avm/res/network/private-endpoint:0.7.1' = [
module storageAccount_storageAccountPrivateEndpoints 'br/public:avm/res/network/private-endpoint:0.7.1' = [
for (privateEndpoint, index) in (storageAccountPrivateEndpoints ?? []): if (privateStorageAccount == 'Enabled') {
name: '${uniqueString(deployment().name, location)}-workspacestorage-PrivateEndpoint-${index}'
scope: resourceGroup(privateEndpoint.?resourceGroupName ?? '')
@@ -553,11 +553,11 @@ output storagePrivateEndpoints array = [
for (pe, i) in ((!empty(storageAccountPrivateEndpoints) && privateStorageAccount == 'Enabled')
? array(storageAccountPrivateEndpoints)
: []): {
name: storageAccount_privateEndpoints[i].outputs.name
resourceId: storageAccount_privateEndpoints[i].outputs.resourceId
groupId: storageAccount_privateEndpoints[i].outputs.groupId
customDnsConfig: storageAccount_privateEndpoints[i].outputs.customDnsConfig
networkInterfaceIds: storageAccount_privateEndpoints[i].outputs.networkInterfaceIds
name: storageAccount_storageAccountPrivateEndpoints[i].outputs.name
resourceId: storageAccount_storageAccountPrivateEndpoints[i].outputs.resourceId
groupId: storageAccount_storageAccountPrivateEndpoints[i].outputs.groupId
customDnsConfig: storageAccount_storageAccountPrivateEndpoints[i].outputs.customDnsConfig
networkInterfaceIds: storageAccount_storageAccountPrivateEndpoints[i].outputs.networkInterfaceIds
}
]

18 changes: 9 additions & 9 deletions avm/res/databricks/workspace/main.json
Original file line number Diff line number Diff line change
@@ -5,8 +5,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.29.47.4906",
"templateHash": "8011778884263076951"
"version": "0.30.23.60470",
"templateHash": "7919315590916710106"
},
"name": "Azure Databricks Workspaces",
"description": "This module deploys an Azure Databricks Workspace.",
@@ -1678,9 +1678,9 @@
"workspace"
]
},
"storageAccount_privateEndpoints": {
"storageAccount_storageAccountPrivateEndpoints": {
"copy": {
"name": "storageAccount_privateEndpoints",
"name": "storageAccount_storageAccountPrivateEndpoints",
"count": "[length(coalesce(parameters('storageAccountPrivateEndpoints'), createArray()))]",
"mode": "serial",
"batchSize": 1
@@ -2543,11 +2543,11 @@
"copy": {
"count": "[length(if(and(not(empty(parameters('storageAccountPrivateEndpoints'))), equals(parameters('privateStorageAccount'), 'Enabled')), array(parameters('storageAccountPrivateEndpoints')), createArray()))]",
"input": {
"name": "[reference(format('storageAccount_privateEndpoints[{0}]', copyIndex())).outputs.name.value]",
"resourceId": "[reference(format('storageAccount_privateEndpoints[{0}]', copyIndex())).outputs.resourceId.value]",
"groupId": "[reference(format('storageAccount_privateEndpoints[{0}]', copyIndex())).outputs.groupId.value]",
"customDnsConfig": "[reference(format('storageAccount_privateEndpoints[{0}]', copyIndex())).outputs.customDnsConfig.value]",
"networkInterfaceIds": "[reference(format('storageAccount_privateEndpoints[{0}]', copyIndex())).outputs.networkInterfaceIds.value]"
"name": "[reference(format('storageAccount_storageAccountPrivateEndpoints[{0}]', copyIndex())).outputs.name.value]",
"resourceId": "[reference(format('storageAccount_storageAccountPrivateEndpoints[{0}]', copyIndex())).outputs.resourceId.value]",
"groupId": "[reference(format('storageAccount_storageAccountPrivateEndpoints[{0}]', copyIndex())).outputs.groupId.value]",
"customDnsConfig": "[reference(format('storageAccount_storageAccountPrivateEndpoints[{0}]', copyIndex())).outputs.customDnsConfig.value]",
"networkInterfaceIds": "[reference(format('storageAccount_storageAccountPrivateEndpoints[{0}]', copyIndex())).outputs.networkInterfaceIds.value]"
}
}
}
Original file line number Diff line number Diff line change
@@ -137,9 +137,13 @@ module testDeployment '../../../main.bicep' = [
customVirtualNetworkResourceId: nestedDependencies.outputs.virtualNetworkResourceId
privateEndpoints: [
{
privateDnsZoneResourceIds: [
nestedDependencies.outputs.privateDNSZoneResourceId
]
privateDnsZoneGroup: {
privateDnsZoneGroupConfigs: [
{
privateDnsZoneResourceId: nestedDependencies.outputs.privateDNSZoneResourceId
}
]
}
service: 'databricks_ui_api'
subnetResourceId: nestedDependencies.outputs.defaultSubnetResourceId
tags: {