Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ALFA-86: Added automation id #600

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

ALFA-86: Added automation id #600

wants to merge 4 commits into from

Conversation

NiklasBack
Copy link

No description provided.

kherP
kherP reviewed Dec 14, 2021
View reviewed changes
Copy link
Contributor

@kherP kherP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Niklas, thank you for making this PR. Is it possible to refactor the code to append the attributes more dynamically?

For instance, introduce a new prop on dropdown level, and append the value of the new prop to the label element with some helps from either a custom directive or viewinit hook. https://stackoverflow.com/questions/44583258/angular-2-dynamic-bind-attribute-name/44606040

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kherP kherP kherP left review comments

@mario-subo mario-subo Awaiting requested review from mario-subo mario-subo is a code owner

@omarVodiaK omarVodiaK Awaiting requested review from omarVodiaK

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NiklasBack @kherP @mario-subo