New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken Helm template #63

Merged

chrislusf merged 1 commit into seaweedfs:master from blampe:template-errorr

Jun 6, 2022

Contributor

blampe commented Jun 6, 2022

values.yaml implicitly had controller: nil which caused templating to fail:

Error: template: seaweedfs-csi-driver/templates/statefulset.yml:19:22: executing "seaweedfs-csi-driver/templates/statefulset.yml" at <.Values.controller.affinity>: nil pointer evaluating interface {}.affinity

This PR

fixes helm template by un-commenting the affinity lines (controller: {} would also work)
adds a Github action to validate the template builds cleanly
re-generates deploy/kubernetes/seaweedfs-csi.yaml with up-to-date values
adds :8888 to the SEAWEEDFS_FILER line to make it slightly clearer which port you probably want (I accidentally provided the 18888 port which broke things looking for 28888).

P.S. - Very cool project!


          Fix broken Helm template

chrislusf merged commit 27586e9 into seaweedfs:master

blampe deleted the template-errorr branch

June 6, 2022 05:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet