Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update semester service's addAcademicYear function to use TypeORM create method #645

Open
natalynyu opened this issue Feb 16, 2023 · 0 comments
Labels
Technical Debt Code requires cleanup

Comments

@natalynyu
Copy link
Contributor

natalynyu commented Feb 16, 2023

The preferred method for creating new instances in TypeORM is to use the .create method. For the most part, we've created instances using new (e.g. new Semester() for making new semester instances). We should, for consistency purposes, change the addAcademicYear function to create new instances using the TypeORM .create method instead.

TypeORM repository documentation: https://github.com/typeorm/typeorm/blob/master/docs/repository-api.md

@natalynyu natalynyu added the Technical Debt Code requires cleanup label Feb 16, 2023
@natalynyu natalynyu changed the title Update semester service's addAcademicYear functions to use TypeORM create method Update semester service's addAcademicYear function to use TypeORM create method Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Technical Debt Code requires cleanup
Projects
None yet
Development

No branches or pull requests

1 participant