Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unseal Wrap trait #638

Closed
L-as opened this issue Jul 6, 2020 · 5 comments
Closed

Unseal Wrap trait #638

L-as opened this issue Jul 6, 2020 · 5 comments
Labels
easy Good for newcomers

Comments

@L-as
Copy link

L-as commented Jul 6, 2020

I don't understand why the Wrap trait has to be sealed.
@seanmonstar
Copy link
Owner

It was sealed in case the design of the trait needed to evolve. For now, since it doesn't seem like things need to really change, we can probably unseal it.

@seanmonstar seanmonstar added the easy Good for newcomers label Jul 6, 2020
@L-as
Copy link
Author

L-as commented Jul 7, 2020

Thanks! I also see a lot of other potentially useful but private code in the crate, like filter_fn. Are these other things always going to be private, or are they potentially going to be made public at some point?

@jxs
Copy link
Collaborator

jxs commented Jul 7, 2020

see #607 (comment)

@jxs jxs changed the title Why is the Wrap trait sealed? Unseal Wrap trait Jul 7, 2020
@hgzimmerman hgzimmerman mentioned this issue Jul 8, 2020
Closed
@aujxn
Copy link
Contributor

aujxn commented Jul 1, 2021

@jxs Should this be closed after #693 and #842 merge?

@jxs
Copy link
Collaborator

jxs commented Jul 1, 2021

yup, makes sense thanks!

@jxs jxs closed this as completed Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unseal Wrap trait hgzimmerman/warp
4 participants
@seanmonstar @jxs @L-as @aujxn