Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSRV builds are broken on macOS #2169

Closed
tnull opened this issue Mar 11, 2024 · 4 comments
Closed

MSRV builds are broken on macOS #2169

tnull opened this issue Mar 11, 2024 · 4 comments

Comments

@tnull
Copy link
Contributor

tnull commented Mar 11, 2024

Unfortunately the bump in #2130 didn't consider the MSRV, i.e., reqwest v0.11.25 MSRV builds are broken on macOS:

error[E0658]: use of unstable library feature 'core_ffi_c'
  --> /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/system-configuration-sys-0.6.0/src/dynamic_store_copy_specific.rs:11:23
   |
11 | pub type __uint32_t = ::core::ffi::c_uint;
   |                       ^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #94501 <https://github.com/rust-lang/rust/issues/94501> for more information

error[E0658]: use of unstable library feature 'core_ffi_c'
  --> /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/system-configuration-sys-0.6.0/src/dynamic_store_copy_specific.rs:16:19
   |
16 | pub type UInt32 = ::core::ffi::c_uint;
   |                   ^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #94501 <https://github.com/rust-lang/rust/issues/94501> for more information

error[E0658]: use of unstable library feature 'core_ffi_c'
   --> /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/system-configuration-sys-0.6.0/src/network_configuration.rs:164:28
    |
164 | pub type _bindgen_ty_286 = ::core::ffi::c_uint;
    |                            ^^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #94501 <https://github.com/rust-lang/rust/issues/94501> for more information

error[E0658]: use of unstable library feature 'core_ffi_c'
  --> /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/system-configuration-sys-0.6.0/src/network_configuration.rs:34:26
   |
34 |         nodename: *const ::core::ffi::c_char,
   |                          ^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #94501 <https://github.com/rust-lang/rust/issues/94501> for more information

error[E0658]: use of unstable library feature 'core_ffi_c'
   --> /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/system-configuration-sys-0.6.0/src/network_configuration.rs:244:23
    |
244 |         mtu_cur: *mut ::core::ffi::c_int,
    |                       ^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #94501 <https://github.com/rust-lang/rust/issues/94501> for more information

error[E0658]: use of unstable library feature 'core_ffi_c'
   --> /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/system-configuration-sys-0.6.0/src/network_configuration.rs:245:23
    |
245 |         mtu_min: *mut ::core::ffi::c_int,
    |                       ^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #94501 <https://github.com/rust-lang/rust/issues/94501> for more information

error[E0658]: use of unstable library feature 'core_ffi_c'
   --> /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/system-configuration-sys-0.6.0/src/network_configuration.rs:246:23
    |
246 |         mtu_max: *mut ::core::ffi::c_int,
    |                       ^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #94501 <https://github.com/rust-lang/rust/issues/94501> for more information

error[E0658]: use of unstable library feature 'core_ffi_c'
   --> /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/system-configuration-sys-0.6.0/src/network_configuration.rs:257:14
    |
257 |         mtu: ::core::ffi::c_int,
    |              ^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #94501 <https://github.com/rust-lang/rust/issues/94501> for more information

error[E0658]: use of unstable library feature 'core_ffi_c'
  --> /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/system-configuration-sys-0.6.0/src/network_reachability.rs:38:27
   |
38 | pub type _bindgen_ty_65 = ::core::ffi::c_uint;
   |                           ^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #94501 <https://github.com/rust-lang/rust/issues/94501> for more information

error[E0658]: use of unstable library feature 'core_ffi_c'
  --> /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/system-configuration-sys-0.6.0/src/network_reachability.rs:60:26
   |
60 |         nodename: *const ::core::ffi::c_char,
   |                          ^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #94501 <https://github.com/rust-lang/rust/issues/94501> for more information

For more information about this error, try `rustc --explain E0658`.
error: could not compile `system-configuration-sys` due to 10 previous errorserror[E0658]: use of unstable library feature 'core_ffi_c'
  --> /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/system-configuration-sys-0.6.0/src/dynamic_store_copy_specific.rs:11:23
   |
11 | pub type __uint32_t = ::core::ffi::c_uint;
   |                       ^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #94501 <https://github.com/rust-lang/rust/issues/94501> for more information

error[E0658]: use of unstable library feature 'core_ffi_c'
  --> /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/system-configuration-sys-0.6.0/src/dynamic_store_copy_specific.rs:16:19
   |
16 | pub type UInt32 = ::core::ffi::c_uint;
   |                   ^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #94501 <https://github.com/rust-lang/rust/issues/94501> for more information

error[E0658]: use of unstable library feature 'core_ffi_c'
   --> /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/system-configuration-sys-0.6.0/src/network_configuration.rs:164:28
    |
164 | pub type _bindgen_ty_286 = ::core::ffi::c_uint;
    |                            ^^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #94501 <https://github.com/rust-lang/rust/issues/94501> for more information

error[E0658]: use of unstable library feature 'core_ffi_c'
  --> /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/system-configuration-sys-0.6.0/src/network_configuration.rs:34:26
   |
34 |         nodename: *const ::core::ffi::c_char,
   |                          ^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #94501 <https://github.com/rust-lang/rust/issues/94501> for more information

error[E0658]: use of unstable library feature 'core_ffi_c'
   --> /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/system-configuration-sys-0.6.0/src/network_configuration.rs:244:23
    |
244 |         mtu_cur: *mut ::core::ffi::c_int,
    |                       ^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #94501 <https://github.com/rust-lang/rust/issues/94501> for more information

error[E0658]: use of unstable library feature 'core_ffi_c'
   --> /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/system-configuration-sys-0.6.0/src/network_configuration.rs:245:23
    |
245 |         mtu_min: *mut ::core::ffi::c_int,
    |                       ^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #94501 <https://github.com/rust-lang/rust/issues/94501> for more information

error[E0658]: use of unstable library feature 'core_ffi_c'
   --> /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/system-configuration-sys-0.6.0/src/network_configuration.rs:246:23
    |
246 |         mtu_max: *mut ::core::ffi::c_int,
    |                       ^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #94501 <https://github.com/rust-lang/rust/issues/94501> for more information

error[E0658]: use of unstable library feature 'core_ffi_c'
   --> /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/system-configuration-sys-0.6.0/src/network_configuration.rs:257:14
    |
257 |         mtu: ::core::ffi::c_int,
    |              ^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #94501 <https://github.com/rust-lang/rust/issues/94501> for more information

error[E0658]: use of unstable library feature 'core_ffi_c'
  --> /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/system-configuration-sys-0.6.0/src/network_reachability.rs:38:27
   |
38 | pub type _bindgen_ty_65 = ::core::ffi::c_uint;
   |                           ^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #94501 <https://github.com/rust-lang/rust/issues/94501> for more information

error[E0658]: use of unstable library feature 'core_ffi_c'
  --> /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/system-configuration-sys-0.6.0/src/network_reachability.rs:60:26
   |
60 |         nodename: *const ::core::ffi::c_char,
   |                          ^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #94501 <https://github.com/rust-lang/rust/issues/94501> for more information

For more information about this error, try `rustc --explain E0658`.
error: could not compile `system-configuration-sys` due to 10 previous errors

It would be great if this could be fixed (i.e., probably the above bump needs to be reverted) and MSRV checks added to the CI, as previously suggested in #1993.

@seanmonstar
Copy link
Owner

Yea, adding back the MSRV checks on other platforms would be a good idea. We can revert this too (would need to target the 0.11.x branch to release a new non-breaking version).

@seanmonstar
Copy link
Owner

This was reverted and published as v0.11.26.

@tnull
Copy link
Contributor Author

tnull commented Mar 14, 2024

This was reverted and published as v0.11.26.

Thank you for the quick response!

@Hywan
Copy link

Hywan commented May 2, 2024

👋

It's good to have reverted #2130, however the issue with system-configuration remains (see #2006). Can we reopen #2006?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants